-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Conv2d, ConvTranspose2d and BatchNorm2d #2244
Conversation
@pmeier I've started seeing |
I'll investigate and get back to you. The problem arises if vision/.circleci/config.yml.in Lines 131 to 135 in cb65590
and the creation of the Lines 51 to 61 in cb65590
I am a little puzzled about what is going on. Unfortunately, I don't have to capacity to debug the CI for now. Could you do that? I would start by checking if the file is created where it is supposed to be. Maybe |
@pmeier we should note that the CI job for What puzzles me is that this CI was working before and just recently stopped working, and I don't have any ideas why that would be the case. |
Isn't vision/.circleci/config.yml.in Lines 131 to 135 in cb65590
|
Oh, you are right, I missed that line. Let me have a closer look at the commit history |
Let's see if #2246 fixes it (I'm not sure) |
* Deprecate Conv2d, ConvTranspose2d and BatchNorm * Fix lint
PyTorch now natively supports empty batches for
Conv2d
,ConvTranspose2d
andBatchNorm2d
, so no need to have our own versions anymore.Follow-up from #2215 which removed those ops. I'm adding the functions back to avoid breaking BC, but I'm raising a error instead to encourage users to replace those ops in their code.