Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix mypy #2246

Closed
wants to merge 2 commits into from
Closed

Try to fix mypy #2246

wants to merge 2 commits into from

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented May 20, 2020

Doesn't know if this will fix it, but worth giving it a try

@pmeier
Copy link
Collaborator

pmeier commented May 20, 2020

I don't think the problem is with the annotations in the file. I think it is either not created or misplaced. Could you verify that the file is actually where it is supposed to be? Something along the line of tree torchvision/ in the CircleCI job.

@pmeier
Copy link
Collaborator

pmeier commented May 20, 2020

Another idea:

I think we should install it with develop. As is, it might be that the installed version is not actually the version that is checked.

@fmassa
Copy link
Member Author

fmassa commented May 20, 2020

@pmeier

I think we should install it with develop. As is, it might be that the installed version is not actually the version that is checked.

That's probably the issue. I've ssh'ed to the build machine and after build the version.py file is not in the project folder.

@fmassa
Copy link
Member Author

fmassa commented May 20, 2020

Superseeded by #2247

@fmassa fmassa closed this May 20, 2020
@fmassa fmassa deleted the try-fix-mypy branch May 20, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants