Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split off dataset download tests #2665

Merged
merged 4 commits into from
Sep 14, 2020
Merged

Split off dataset download tests #2665

merged 4 commits into from
Sep 14, 2020

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Sep 10, 2020 •
edited
Loading

Closes #2617

ToDo:

  • retry download test if initial request fails
  • run download on a schedule

@pmeier pmeier requested a review from fmassa September 10, 2020 15:36
fmassa
fmassa approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This first part is great, thanks!

Looking forward to the next part where we add a CI job for these tests. Also, having a CI that runs on a schedule would open the door to longer / more costly integration tests, which would be very valuable as well.

@fmassa fmassa merged commit 3b31b72 into pytorch:master Sep 14, 2020
@fmassa
Copy link
Member

fmassa commented Sep 14, 2020

Actually, you forgot to disable the test on TravisCI. We will be killing TravisCI in the future, but in the meantime, can you just disable this test there?

This was referenced Sep 14, 2020
Closed
Merged
@pmeier pmeier deleted the test-dataset-download branch September 15, 2020 05:29
@pmeier pmeier mentioned this pull request Sep 22, 2020
Merged
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
@pmeier @bryant1410
Split off dataset download tests (pytorch#2665)
89beccf 
* split off tests for dataset downloadability

* ignore download tests during normal test suite

* lint

* add retry mechanic
vfdev-5 pushed a commit to Quansight/vision that referenced this pull request Dec 4, 2020
@pmeier @vfdev-5
Split off dataset download tests (pytorch#2665)
8d7d7f3 
* split off tests for dataset downloadability

* ignore download tests during normal test suite

* lint

* add retry mechanic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test dataset downloadability on a schedule
2 participants
@pmeier @fmassa