limit requests per time in download tests #2699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmassa
approved these changes
Sep 24, 2020
|
@fmassa Given that |
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
vfdev-5
pushed a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an afterthought to #2665. Instead of blindly waiting 2 seconds after each request, with this we only wait if the interval between two requests to the same server is smaller than 2 seconds.
Right now this only adds (fairly minimal) overhead, since all requests target the same server. Even if the download tests comprise all datasets from
torchvisionthe impact of this optimization will still be low, since the tests are only run once per day.Still, I think this is good to have since it makes the intention behind the wait time more clear without adding any complexity for someone writing new tests. @fmassa If you disagree with me here, feel free to close this.