Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partially enable type checking for .models #2668

Merged
merged 3 commits into from
Sep 22, 2020
Merged

partially enable type checking for .models #2668

merged 3 commits into from
Sep 22, 2020

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Sep 11, 2020

No description provided.

pmeier
pmeier commented Sep 11, 2020
View reviewed changes
mypy.ini Show resolved Hide resolved
torchvision/models/googlenet.py Outdated Show resolved Hide resolved
@pmeier pmeier requested a review from fmassa September 11, 2020 14:47
@codecov
Copy link

codecov bot commented Sep 11, 2020 •
edited
Loading

Codecov Report

Merging #2668 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2668   +/-   ##
=======================================
  Coverage   72.42%   72.42%           
=======================================
  Files          95       95           
  Lines        8246     8246           
  Branches     1308     1308           
=======================================
  Hits         5972     5972           
  Misses       1859     1859           
  Partials      415      415
Impacted Files Coverage Δ
torchvision/models/googlenet.py 82.32% <100.00%> (ø)
torchvision/models/inception.py 84.64% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c36dc43...937b956. Read the comment docs.

fmassa
fmassa approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, conditioned on @eellison answer to the Union part.

@pmeier
Copy link
Collaborator Author

pmeier commented Sep 14, 2020

@fmassa I'll rebase after @eellison s review.

@pmeier pmeier mentioned this pull request Sep 17, 2020
Merged
18 tasks
@fmassa fmassa merged commit 8dfcff7 into pytorch:master Sep 22, 2020
@pmeier pmeier deleted the typehints-models branch October 21, 2020 15:07
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
@pmeier @bryant1410
partially enable type checking for .models (pytorch#2668)
a9b7926 
* partially enable mypy for .models

* fix existing errors

* ignore error instead of using Union
vfdev-5 pushed a commit to Quansight/vision that referenced this pull request Dec 4, 2020
@pmeier @vfdev-5
partially enable type checking for .models (pytorch#2668)
d7019f3 
* partially enable mypy for .models

* fix existing errors

* ignore error instead of using Union
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eellison eellison eellison left review comments

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmeier @fmassa @eellison