Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated transforms docs #2820

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Updated transforms docs #2820

merged 1 commit into from
Oct 16, 2020

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Oct 15, 2020

Description:

  • Added missing transforms
  • Added missing methods
  • Restructured sections

@vfdev-5 vfdev-5 force-pushed the fix-docs-transforms branch 2 times, most recently from c8f74bb to fc87dc2 Compare October 15, 2020 15:20
@codecov
Copy link

codecov bot commented Oct 16, 2020 •
edited
Loading

Codecov Report

Merging #2820 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2820   +/-   ##
=======================================
  Coverage   73.26%   73.26%           
=======================================
  Files          99       99           
  Lines        8778     8778           
  Branches     1387     1387           
=======================================
  Hits         6431     6431           
  Misses       1920     1920           
  Partials      427      427
Impacted Files Coverage Δ
torchvision/transforms/functional.py 80.44% <ø> (ø)
torchvision/transforms/transforms.py 81.04% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 072d8b2...badad9b. Read the comment docs.

@vfdev-5 vfdev-5 requested a review from fmassa October 16, 2020 11:40
fmassa
fmassa reviewed Oct 16, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR!

There is a submodule change, is this expected?

docs/source/transforms.rst Outdated Show resolved Hide resolved
@vfdev-5 vfdev-5 force-pushed the fix-docs-transforms branch from 565420b to badad9b Compare October 16, 2020 13:59
fmassa
fmassa approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@fmassa fmassa merged commit a055980 into pytorch:master Oct 16, 2020
@vfdev-5 vfdev-5 deleted the fix-docs-transforms branch October 16, 2020 14:27
fmassa pushed a commit that referenced this pull request Oct 16, 2020
@vfdev-5 @fmassa
Updated transforms docs (#2820)
55c95eb
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
@vfdev-5 @bryant1410
Updated transforms docs (pytorch#2820)
2fd34d3
vfdev-5 added a commit to Quansight/vision that referenced this pull request Dec 4, 2020
@vfdev-5
Updated transforms docs (pytorch#2820)
4974f73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vfdev-5 @fmassa