Added annotation typing to squeezenet #2865
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2865 +/- ##
=======================================
Coverage 73.36% 73.36%
=======================================
Files 99 99
Lines 8787 8787
Branches 1387 1387
=======================================
Hits 6447 6447
Misses 1916 1916
Partials 424 424
Continue to review full report at Codecov.
|
torchvision/models/squeezenet.py
Outdated
| x = self.features(x) | ||
| x = self.classifier(x) | ||
| return torch.flatten(x, 1) | ||
|
|
||
|
|
||
| def _squeezenet(version, pretrained, progress, **kwargs): | ||
| def _squeezenet(version: str, pretrained: bool, progress: bool, **kwargs) -> SqueezeNet: |
There was a problem hiding this comment.
nit: you are not typing kwargs here.
Also, should we start enabling mypy tests for each one of the files that we enable?
There was a problem hiding this comment.
Nice catch! Just fixed it, that would be good, my local mypy run didn't catch this.
But I'm unsure about how to proceed with this? Any suggestion about the mypy.ini?
There was a problem hiding this comment.
This did not show up since we don't enforce annotations yet. If we hit a significant coverage we should enable disallow_untyped_defs. Unfortunately, mypy makes no difference between an untyped and partially typed definition and thus this is disabled for now.
* style: Added annotation typing for squeezenet * feat: Added typing for kwargs
* style: Added annotation typing for squeezenet * feat: Added typing for kwargs
Hi there!
As per #2025, annotation typing are welcome in torchvision. So, this PR focuses on
torchvision.models.squeezenetthis PR!Any feedback is welcome!