Fixed typing in constructors of models submodules #2875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
approved these changes
Oct 23, 2020
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
* fix: Fixed constructor typing in models._utils * fix: Fixed constructor typing in models.alexnet * fix: Fixed constructor typing in models.mnasnet * fix: Fixed constructor typing in models.squeezenet
vfdev-5
pushed a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
* fix: Fixed constructor typing in models._utils * fix: Fixed constructor typing in models.alexnet * fix: Fixed constructor typing in models.mnasnet * fix: Fixed constructor typing in models.squeezenet
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
This is small fix for the PRs introducing typing in
_utils,alexnet,mnasnet,squeezenet#2854 #2856 #2859 #2865Since it was my mistake to forget them in the first place, I figured I'd open this one 😅
Any feedback is welcome!