Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TorchVision cocoapods package #3999

Closed
wants to merge 3 commits into from
Closed

TorchVision cocoapods package #3999

wants to merge 3 commits into from

Conversation

elb3k
Copy link

@elb3k elb3k commented Jun 8, 2021

Created Cocoapods package with libtorchvision_ops.a for iOS development.
Cocoapods is created with similar fashion to LibTorch.

Library is compiled using torch downloaded from LibTorch. (Provided build_podspec.sh to create archive)
Currently uploaded test version of package to Cocoapods trunk with name LibTorch_vision_ops.
Need to modify author and homepage on LibTorch_vision.ops.podspec file to main branch. (Currently on fork).

Once PR Is accepted, I will pull package from Cocoapods.

@fmassa
Copy link
Member

fmassa commented Jun 9, 2021

@husthyc can you have a look?

@fmassa fmassa requested a review from husthyc June 9, 2021 08:24
@husthyc
Copy link
Contributor

husthyc commented Jun 11, 2021

@elb3k Thanks for drafting this PR. We are planning to do the Cocoapod release in recent days which aligns with the main PyTorch 1.9.0 release day.

I think we cannot build the lib on a local machine and push to Cocoapod because if we do that, the debug symbols in the static lib will contain your personal machine's paths. Basically what we will do is we will trigger a job on the CI machine and upload the zip to AWS s3 bucket from there.

Can you hold this PR for some days and see if our official release works? Thanks.

@elb3k
Copy link
Author

elb3k commented Jun 11, 2021

@elb3k Thanks for drafting this PR. We are planning to do the Cocoapod release in recent days which aligns with the main PyTorch 1.9.0 release day.

I think we cannot build the lib on a local machine and push to Cocoapod because if we do that, the debug symbols in the static lib will contain your personal machine's paths. Basically what we will do is we will trigger a job on the CI machine and upload the zip to AWS s3 bucket from there.

Can you hold this PR for some days and see if our official release works? Thanks.

@husthyc Yes.

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I added a few comments about nits I spotted, let me know what you think.

.gitignore Outdated Show resolved Hide resolved
ios/.gitignore Outdated Show resolved Hide resolved
ios/LibTorch_vision_ops.podspec Outdated Show resolved Hide resolved
@fmassa
Copy link
Member

fmassa commented Jun 16, 2021

Hi,

Thanks a lot for the PR!

We have released a cocoapods package with the 0.10.0 release, and it has been merged in #4055

Thanks again for your help!

@fmassa fmassa closed this Jun 16, 2021
@elb3k
Copy link
Author

elb3k commented Jun 16, 2021

Hi,

Thanks a lot for the PR!

We have released a cocoapods package with the 0.10.0 release, and it has been merged in #4055

Thanks again for your help!

Hi, I am glad to hear that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants