-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TorchVision cocoapods package #3999
Conversation
@husthyc can you have a look? |
@elb3k Thanks for drafting this PR. We are planning to do the Cocoapod release in recent days which aligns with the main PyTorch 1.9.0 release day. I think we cannot build the lib on a local machine and push to Cocoapod because if we do that, the debug symbols in the static lib will contain your personal machine's paths. Basically what we will do is we will trigger a job on the CI machine and upload the zip to AWS s3 bucket from there. Can you hold this PR for some days and see if our official release works? Thanks. |
@husthyc Yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I added a few comments about nits I spotted, let me know what you think.
Hi, Thanks a lot for the PR! We have released a cocoapods package with the 0.10.0 release, and it has been merged in #4055 Thanks again for your help! |
Hi, I am glad to hear that. |
Created Cocoapods package with
libtorchvision_ops.a
for iOS development.Cocoapods is created with similar fashion to LibTorch.
Library is compiled using torch downloaded from
LibTorch
. (Providedbuild_podspec.sh
to create archive)Currently uploaded test version of package to Cocoapods trunk with name
LibTorch_vision_ops
.Need to modify author and homepage on
LibTorch_vision.ops.podspec
file to main branch. (Currently on fork).Once PR Is accepted, I will pull package from Cocoapods.