Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] podspec file for Cocoapods release, pod name: LibTorchvision #4055

Merged
merged 2 commits into from
Jun 16, 2021
Merged

[iOS] podspec file for Cocoapods release, pod name: LibTorchvision #4055

merged 2 commits into from
Jun 16, 2021

Conversation

husthyc
Copy link
Contributor

@husthyc husthyc commented Jun 15, 2021 •
edited
Loading

Stack from ghstack:

husthyc added a commit that referenced this pull request Jun 15, 2021
@husthyc
[iOS] podspec file for Cocoapods release, pod name: LibTorchvision
e3abdee 
ghstack-source-id: 60901b893bb99ae2f7e494ab231c45645c418ee8
Pull Request resolved: #4055
husthyc added a commit that referenced this pull request Jun 15, 2021
@husthyc
[iOS] podspec file for Cocoapods release, pod name: LibTorchvision
60f4fb3 
ghstack-source-id: 4b86914bffec885ef189dd54c07ca664aab34b2a
Pull Request resolved: #4055
@husthyc husthyc requested review from xta0 and fmassa June 15, 2021 05:33
xta0
xta0 approved these changes Jun 15, 2021
View reviewed changes
Copy link

@xta0 xta0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NicolasHug
Copy link
Member

Thanks !

@NicolasHug NicolasHug merged commit 307443e into gh/husthyc/6/base Jun 16, 2021
@fmassa
Copy link
Member

fmassa commented Jun 16, 2021

@NicolasHug FYI this PR was merged in the wrong branch. ghstack doesn't work with torchvision, so we will need to cherry-pick it to the master branch

NicolasHug pushed a commit to NicolasHug/vision that referenced this pull request Jun 16, 2021
@husthyc @NicolasHug
[iOS] podspec file for Cocoapods release, pod name: LibTorchvision (p…
1c3e811 
…ytorch#4055)
@NicolasHug NicolasHug mentioned this pull request Jun 16, 2021
Merged
@fmassa fmassa mentioned this pull request Jun 16, 2021
Closed
fmassa added a commit that referenced this pull request Jun 16, 2021
@NicolasHug @husthyc @fmassa
[iOS] podspec file for Cocoapods release, pod name: LibTorchvision (#…
686ff59 
…4055) (#4074)

Co-authored-by: Yuchen Huang <hyc@fb.com>
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
facebook-github-bot pushed a commit that referenced this pull request Jun 21, 2021
@NicolasHug @husthyc
@fmassa @facebook-github-bot
[fbsync] [iOS] podspec file for Cocoapods release, pod name: LibTorch…
6c39544 
…vision (#4055) (#4074)

Summary:

Reviewed By: fmassa

Differential Revision: D29264320

fbshipit-source-id: dc78f7e8306e05c8fbdd64c79d81b7260c36c4ee

Co-authored-by: Yuchen Huang <hyc@fb.com>
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
@facebook-github-bot facebook-github-bot deleted the gh/husthyc/6/head branch July 16, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xta0 xta0 xta0 approved these changes

@fmassa fmassa Awaiting requested review from fmassa

Assignees
No one assigned
Labels
cla signed topic: mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@husthyc @NicolasHug @fmassa @xta0 @facebook-github-bot