Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaned-up coco evaluation code #4453

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Cleaned-up coco evaluation code #4453

merged 1 commit into from
Sep 21, 2021

Conversation

prabhat00155
Copy link
Contributor

@prabhat00155 prabhat00155 commented Sep 20, 2021 •
edited by pytorch-probot bot
Loading

Resolves #4368.

cc @datumbox

@prabhat00155
Copy link
Contributor Author

Logs of training run with and without these changes(epoch=5):
nochange_run.txt
withchange_run.txt

datumbox
datumbox approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@prabhat00155 prabhat00155 merged commit 526a69e into pytorch:main Sep 21, 2021
@prabhat00155 prabhat00155 deleted the prabhat00155/coco_eval_cleanup branch September 21, 2021 10:18
@fmassa
Copy link
Member

fmassa commented Sep 21, 2021

Thanks Prabhat!

@fmassa fmassa mentioned this pull request Sep 21, 2021
Closed
facebook-github-bot pushed a commit that referenced this pull request Sep 30, 2021
@NicolasHug @facebook-github-bot
[fbsync] Cleaned-up coco evaluation code (#4453)
709cc89 
Reviewed By: datumbox

Differential Revision: D31268048

fbshipit-source-id: e209ac9447e172972baeb322d592de15e4806383
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox datumbox approved these changes

Assignees
No one assigned
Labels
cla signed code quality module: reference scripts
Projects
None yet
Milestone
No milestone
4 participants
@prabhat00155 @fmassa @datumbox @facebook-github-bot