Avoid / silence warnings in refactored tests

[NicolasHug]

cc @pmeier

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7905

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures, 7 Unrelated Failures

As of commit 3bd42df with merge base 25ec3f2 ():

NEW FAILURES - The following jobs have failed:

• linux (linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh)
• macos (macos-m1-12) / macos-job (gh)
• unittests-linux (3.8, linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh)
• unittests-macos (3.11, macos-12) / macos-job (gh)
• unittests-macos (3.8, macos-m1-12) / macos-job (gh)
• unittests-macos (3.9, macos-12) / macos-job (gh)
• unittests-prototype (3.8, linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh)
• unittests-windows (3.10, windows.4xlarge, cpu) / windows-job (gh)

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

• macos (macos-12) / macos-job (gh)
• unittests-macos (3.10, macos-12) / macos-job (gh)
• unittests-macos (3.8, macos-12) / macos-job (gh)
• unittests-windows (3.11, windows.4xlarge, cpu) / windows-job (gh)
• unittests-windows (3.8, windows.4xlarge, cpu) / windows-job (gh)
• unittests-windows (3.9, windows.4xlarge, cpu) / windows-job (gh)
• windows (windows.4xlarge, cpu) / windows-job (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[NicolasHug]

This silences the following. Maybe we can make the silencing more localized, or just avoid testing unnecessary configurations. Maybe we should assert the warning somewhere. 🤷‍♂️

(pt) ➜  vision git:(njflajnlajn) ✗ pytest test/test_transforms_v2_refactored.py -k rotate
=============================================================== test session starts ===============================================================
platform linux -- Python 3.9.12, pytest-7.0.1, pluggy-1.0.0
rootdir: /home/nicolashug/dev/vision, configfile: pytest.ini
plugins: typeguard-2.13.3, cov-3.0.0, mock-3.7.0, anyio-3.5.0
collected 3625 items / 2978 deselected / 647 selected                                                                                             

test/test_transforms_v2_refactored.py ............................................ssssssssssssssssssssssssssssssssssssssssssss............. [ 15%]
.........................................ssssssssssssssssssssssssssssssssssssssssssssssssssssss.....................ssssss................. [ 37%]
........................................................................................................................................... [ 58%]
........................................................................................................................................... [ 80%]
.................................................................................................................................           [100%]

================================================================ warnings summary =================================================================
test/test_transforms_v2_refactored.py: 96 warnings
  /home/nicolashug/dev/vision/torchvision/transforms/v2/functional/_geometry.py:982: UserWarning: The provided center argument has no effect on the result if expand is True
    warnings.warn("The provided center argument has no effect on the result if expand is True")

test/test_transforms_v2_refactored.py: 96 warnings
  /home/nicolashug/dev/vision/torchvision/transforms/v2/functional/_geometry.py:1021: UserWarning: The provided center argument has no effect on the result if expand is True
    warnings.warn("The provided center argument has no effect on the result if expand is True")

test/test_transforms_v2_refactored.py: 36 warnings
  /home/nicolashug/dev/vision/torchvision/transforms/v2/functional/_geometry.py:1037: UserWarning: The provided center argument has no effect on the result if expand is True
    warnings.warn("The provided center argument has no effect on the result if expand is True")

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

[pmeier]

Since we have seen time and time again that in practice center does have an effect with expand=True should we maybe downgrade this into a note in the documentation instead? cc @vfdev-5

[pmeier]

Thanks! Should we maybe turn all warnings into errors for this file to prevent this in the future?

[NicolasHug]

Should we maybe turn all warnings into errors for this file to prevent this in the future?

Why not, although

pytestmark = pytest.mark.filterwarnings("error")

from https://docs.pytest.org/en/7.1.x/how-to/capture-warnings.html#pytest-mark-filterwarnings seems to conflict with our filter, so I'll leave it out for now.