Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade warnign for F.rotate with center and expand=True #7907

Merged
merged 4 commits into from
Aug 31, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Aug 30, 2023

Acts on

if center is not None:
if expand:
# TODO: Do we actually want to warn, or just document this?
warnings.warn("The provided center argument has no effect on the result if expand is True")

which came up again in #7905 (comment).

cc @vfdev-5

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 30, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7907

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 5 Unrelated Failures

As of commit d32bfeb with merge base b828671 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when green, thanks

torchvision/transforms/v2/_geometry.py Outdated Show resolved Hide resolved
@pmeier pmeier merged commit fb115c2 into pytorch:main Aug 31, 2023
@pmeier pmeier deleted the center-expand branch August 31, 2023 15:10
@github-actions
Copy link

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

pmeier added a commit to pmeier/vision that referenced this pull request Aug 31, 2023
…ue (pytorch#7907)

Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
facebook-github-bot pushed a commit that referenced this pull request Sep 6, 2023
…7907)

Summary: Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>

Reviewed By: matteobettini

Differential Revision: D48900372

fbshipit-source-id: a66b10e7b50175020c317bc274f14d76717b10c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants