[FSDPv2] Move the module to xla device #6525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This change allows moving module to the xla device during wrapping such that the caller doesn't need to move the module to the xla device. Test Plan: python test/spmd/test_fsdp_v2.py -v -k test_fsdp_v2_cpu_model
jonb377
approved these changes
Feb 13, 2024
| self._orig_module = module | ||
| # Let's move the module to xla device in case it's not moved | ||
| # by the caller already. | ||
| self._orig_module = module.to(xm.xla_device()) |
There was a problem hiding this comment.
Is this a no-op if the model is already on xla?
|
Thanks Jon for the quick review! |
5 tasks
amithrm
pushed a commit
to amithrm/xla
that referenced
this pull request
Mar 1, 2024
Summary: This change allows moving module to the xla device during wrapping such that the caller doesn't need to move the module to the xla device. Test Plan: python test/spmd/test_fsdp_v2.py -v -k test_fsdp_v2_cpu_model
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
Summary: This change allows moving module to the xla device during wrapping such that the caller doesn't need to move the module to the xla device. Test Plan: python test/spmd/test_fsdp_v2.py -v -k test_fsdp_v2_cpu_model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change allows moving module to the xla device during wrapping such that the caller doesn't need to move the module to the xla device.
Test Plan:
python test/spmd/test_fsdp_v2.py -v -k test_fsdp_v2_cpu_model