Add dynamo expand test. #6659
Merged
Add dynamo expand test. #6659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 1, 2024
miladm
reviewed
Mar 4, 2024
test/dynamo/test_dynamo.py
Outdated
| @@ -568,6 +568,24 @@ def test_all_cpu_tensor(self): | |||
| self.assertIn('MarkStep', met.counter_names()) | |||
|
|
|||
|
|
|||
| class DynamoOperationsTests(test_utils.XlaTestCase): | |||
There was a problem hiding this comment.
can we add a flag to skip this test while we address the corresponding bug you will soon open on "expand failing on dynamo"
|
You can add a .torch_pin to build with your patch PR. Following the instructions here: https://github.com/pytorch/xla/tree/master/torch_patches Such that we don't need to add any guards. We just need to land the two patches together. |
|
Great, looks like all tests pass! Please ping me once your upstream PR is approved. Also, we need to remove the .torch_pin before landing the PR. |
ysiraichi
force-pushed
the
ysiraichi/add-test-expand-return
branch
from
b3aa233
to
372c226
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test for #5837. The fix was introduced in PyTorch main repository (pytorch/pytorch#121007), but we need PyTorch/XLA for actually exercising the (previously) failing test case.
cc @miladm @JackCaoG