Add dynamo torch.Tensor.new test.
#6661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysiraichi
changed the base branch from
master
to
ysiraichi/add-test-expand-return
|
This PR should only be merged after: |
ysiraichi
force-pushed
the
ysiraichi/add-test-new-with-sizes
branch
from
c465d5a to
c3bc422
Compare
ysiraichi
force-pushed
the
ysiraichi/add-test-new-with-sizes
branch
from
c3bc422 to
52fa414
Compare
ysiraichi
force-pushed
the
ysiraichi/add-test-new-with-sizes
branch
from
52fa414 to
3f30293
Compare
ysiraichi
requested review from
will-cromar,
JackCaoG,
yeounoh,
mateuszlewko and
stgpetrovic
as code owners
ysiraichi
changed the base branch from
ysiraichi/add-test-expand-return
to
master
|
I'm moving this one forward, since #6659 will take some time to get merged. |
|
@JackCaoG Could you take a look at it whenever you have some time? |
|
change lgtm but somehow CI doesn't get trigger. Can you do another push to the branch to see if it will trigger the CI? Otherwise start a new pr might be better. |
|
@JackCaoG Is this ok to land? All the CI test are passing, now. |
JackCaoG
reviewed
Apr 8, 2024
| def foo(x): | ||
| return x.new(*x.size()) + x | ||
|
|
||
| optfoo = torch.compile(backend="openxla")(foo) |
There was a problem hiding this comment.
lol is it a new way of calling compile? it used to be torch.compile(foo, backend="openxla")
JackCaoG
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test for #6009.
The actual fix is implemented in the PyTorch main repository: pytorch/pytorch#121075
@miladm @JackCaoG