Build torchvision from the pytorch pin in ansible #6756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will-cromar
requested review from
JackCaoG,
yeounoh,
mateuszlewko and
stgpetrovic
as code owners
JackCaoG
approved these changes
Mar 15, 2024
vanbasten23
reviewed
Mar 22, 2024
| @@ -20,25 +20,6 @@ | |||
| dest: "{{ (src_root, 'pytorch/xla') | path_join }}" | |||
| version: "{{ xla_git_rev }}" | |||
|
|
|||
| - name: Find *.diff files in pytorch/xla/openxla_patches | |||
There was a problem hiding this comment.
I wonder why we don't need the openxla patches anymore.
There was a problem hiding this comment.
The patches are applied by bazel automatically now.
lsy323
pushed a commit
that referenced
this pull request
Apr 24, 2024
lsy323
added a commit
that referenced
this pull request
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of installing the last stable
torchvisionin our image, install the pinned version from the PyTorch repository.Also remove XLA patching that we don't need anymore 🎊
Tested:
ansible-playbook playbook.yaml -e "stage=build arch=amd64 accelerator=tpu bundle_libtpu=0"Will also test with TPU CI to since it uses an image built with ansible.