Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build torchvision from the pytorch pin in ansible (#6756) #6960

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

lsy323
Copy link
Collaborator

@lsy323 lsy323 commented Apr 24, 2024

No description provided.

Copy link
Collaborator

@vanbasten23 vanbasten23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is to bring how we build torcvision from master branch to the release branch?

@lsy323
Copy link
Collaborator Author

lsy323 commented Apr 24, 2024

The change is to bring how we build torcvision from master branch to the release branch?

Yes, if a build trigger is targeted at a branch, the dockerfile in the target branch will be used.

@lsy323
Copy link
Collaborator Author

lsy323 commented Apr 24, 2024

Verified by building image locally

docker build --progress=plain -f=Dockerfile .  --build-arg=python_version=3.10 --build-arg=ansible_vars='{"accelerator":"tpu","arch":"amd64","bundle_libtpu":"1","cuda_version":"11.8","nightly_release":"true","package_version":"2.4.0","python_version":"3.10","pytorch_git_rev":"v2.3.0-rc12","xla_git_rev":"a09727999bd1390107e35b5e7dfbd9a0162bfbde"}'  -t=local_image

@lsy323 lsy323 merged commit b94c014 into r2.3 Apr 24, 2024
18 checks passed
@lsy323 lsy323 deleted the lsiyuan/backport-torchvision branch April 24, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants