Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Remove reshape lowering (#6801) #6847

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

wonjoolee95
Copy link
Collaborator

Backport #6801.

After merging #6801 to nightly earlier this week, we didn't see any observable regression in our dashboards.

We'll keep monitoring for a few more days and merge this once we're confident that there is no regression according to our dashboards.

Copy link
Collaborator

@JackCaoG JackCaoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure torchbench data is up to date.

@lsy323
Copy link
Collaborator

lsy323 commented Apr 3, 2024

One GPU test is failing, now sure if it's persistent //test/cpp:test_aten_xla_tensor_6

Triggered rerun on the failed GPU testing job.

Copy link
Collaborator

@lsy323 lsy323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPU test passed after rerunning, merging.

@lsy323 lsy323 merged commit 6e4b2ed into r2.3 Apr 3, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants