Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Remove reshape lowering (#6801) #6847

Merged
merged 1 commit into from
Apr 3, 2024
Merged

[Backport] Remove reshape lowering (#6801) #6847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions codegen/xla_native_functions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,6 @@ supported:
- narrow_copy
- pixel_shuffle
- pixel_unshuffle
- reshape
- select_backward
- select.int
- slice.Tensor
Expand Down Expand Up @@ -413,8 +412,6 @@ symint:
- narrow_copy
- select_backward
- select.int
# See Note: [functionalization and CompositeExplicitAutograd]
- reshape
# See Note: [Disabling functionalization]
- expand
- view
Expand Down
10 changes: 0 additions & 10 deletions torch_xla/csrc/aten_xla_type.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3653,16 +3653,6 @@ at::Tensor XLANativeFunctions::pixel_unshuffle(const at::Tensor& self,
pixel_unshuffle)>::call(self, downscale_factor);
}

at::Tensor XLANativeFunctions::reshape_symint(const at::Tensor& self,
c10::SymIntArrayRef shape) {
// See Note: [Disabling functionalization]
if (runtime::sys_util::GetEnvBool("XLA_DISABLE_FUNCTIONALIZATION", false)) {
return at::native::reshape_symint(self, shape);
}
return at::functionalization::functionalize_aten_op_symint<ATEN_OP(
reshape)>::call(self, shape);
}

at::Tensor XLANativeFunctions::select_backward_symint(
const at::Tensor& grad_output, c10::SymIntArrayRef input_sizes, int64_t dim,
c10::SymInt index) {
Expand Down
Loading