Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert expand test with dynamo #6950

Merged
merged 1 commit into from
Apr 22, 2024
Merged

revert expand test with dynamo #6950

merged 1 commit into from
Apr 22, 2024

Conversation

bdhirsh
Copy link
Collaborator

@bdhirsh bdhirsh commented Apr 22, 2024

pytorch/pytorch#121007 needs to be partially reverted / forward-fixed, so I'm temporarily removing these tests to get CI green on my forward fix: pytorch/pytorch#124488

Once the forward fix lands, we can re-enable the test after setting this config for XLA: (cc @ysiraichi, do you mind making that fix after the forward-fix lands on the core side?)

torch._functorch.config.view_replay_for_aliased_outputs = True

@bdhirsh bdhirsh requested review from ysiraichi and JackCaoG April 22, 2024 18:04
@JackCaoG JackCaoG merged commit 62a2b11 into master Apr 22, 2024
4 of 5 checks passed
@JackCaoG JackCaoG deleted the xla_view_replay_fix branch April 22, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants