Re-land: dynamo expand test with view-replay. #6958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackCaoG
reviewed
Apr 24, 2024
test/dynamo/test_dynamo.py
Outdated
| @@ -671,6 +676,22 @@ def foo(x): | |||
| self.assertEqual(expected.dtype, actual.dtype) | |||
| self.assertEqual(expected.device, actual.device) | |||
|
|
|||
| def test_return_expand(self): | |||
| _set_view_replay_for_aliased_outputs() | |||
There was a problem hiding this comment.
do we want to leave this options to always true througout the test? If the intention is to always set this to True for PyTorch/XLA, you should set it in https://github.com/pytorch/xla/blob/master/torch_xla/__init__.py .
JackCaoG
reviewed
Apr 24, 2024
torch_patches/.torch_pin
Outdated
| @@ -0,0 +1 @@ | |||
| 680a89e2ced8f45b87b7fd0509c07cf6b768be14 | |||
There was a problem hiding this comment.
why do we need a pin? I thought Brian's change already merged to main.
There was a problem hiding this comment.
It was reverted.
JackCaoG
approved these changes
Apr 24, 2024
|
@JackCaoG @vanbasten23 I'm puzzled by this CI failure. Doesn't TPU CI build take the |
|
yea TPU CI does not take into pin into account yet. I think it is oK to merge once you remove the pin. @will-cromar FYI |
ysiraichi
force-pushed
the
ysiraichi/add-expand-test-retry
branch
from
72426d7 to
2c79b7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #6950, re-introducing the dynamo expand test while setting the
view_replay_for_aliased_outputsdynamo configuration that uses the outputs of the functionalization step for reconstructing output views.cc @miladm @JackCaoG