-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace depracated Numpy dtypes #395
Conversation
Do we just want to force this to int64 to ensure 64-bit precision? |
I also think there is an np.float somewhere in |
Codecov Report
@@ Coverage Diff @@
## main #395 +/- ##
=======================================
Coverage 93.80% 93.80%
=======================================
Files 65 65
Lines 11038 11061 +23
=======================================
+ Hits 10354 10376 +22
- Misses 684 685 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I changed them to Apparently |
The tests don't pass locally on Python 3.9, which doesn't seem to be use in the CI at all! |
Python 3.9 test runs added in #396 |
pyresample/bucket/__init__.py
Outdated
x_idxs = da.floor((proj_x - adef.area_extent[0]) / x_res).astype(int) | ||
y_idxs = da.floor((adef.area_extent[3] - proj_y) / y_res).astype(int) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want these to be np.int64
too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. Thanks, missed them in the previous change 🤦♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small double check on one remaining int
, otherwise LGTM
With a new production chain I noticed the following depraction warning in the logs:
This PR replaces all the usages of
np.int
,np.float
andnp.bool
with the preferred versions listed in the third column of the Release Notes for 1.20.0.git diff origin/main **/*py | flake8 --diff