Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.9 to CI runs and use it for the experimental run #396

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Nov 12, 2021

Python 3.9 wasn't used to run the unit tests. This'll add it, and swap the experimental test runs to it.

  • Tests passed

@pnuu pnuu mentioned this pull request Nov 12, 2021
2 tasks
@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #396 (4ced7ae) into main (ee7c1b9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #396   +/-   ##
=======================================
  Coverage   93.80%   93.80%           
=======================================
  Files          65       65           
  Lines       11038    11038           
=======================================
  Hits        10354    10354           
  Misses        684      684           
Flag Coverage Δ
unittests 93.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee7c1b9...4ced7ae. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 93.606% when pulling 4ced7ae on pnuu:ci-python-3.9 into ee7c1b9 on pytroll:main.

@djhoese
Copy link
Member

djhoese commented Nov 12, 2021

@gerritholl had brought up that numpy will drop 3.7 support by the end of the year. Should we drop 3.7 testing now?

@djhoese
Copy link
Member

djhoese commented Nov 17, 2021

Thoughts on dropping Python 3.7 in the tests @gerritholl @mraspaud @pnuu ?

@gerritholl
Copy link
Collaborator

Thoughts on dropping Python 3.7 in the tests

Fine with me, although if we follow NEP 29 strictly, then we should wait for 2021-12-26 to do so (or for the first release after this date).

@djhoese
Copy link
Member

djhoese commented Nov 17, 2021

Ok so maybe we just merge this?

@gerritholl
Copy link
Collaborator

I think so. Maybe by Christmas we can add Python 3.10 tests and drop Python 3.7 at the same time.

@djhoese djhoese merged commit d219e1f into pytroll:main Nov 17, 2021
@pnuu pnuu deleted the ci-python-3.9 branch November 18, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants