eth/signature: fix prefix_message for multibyte characters (#120)

q9f · Jun 24, 2022 · 7cba13b · 7cba13b
1 parent bb640c7
commit 7cba13b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/eth/signature.rb b/lib/eth/signature.rb
@@ -38,7 +38,7 @@ class SignatureError < StandardError; end
     # @param message [String] the message string to be prefixed.
     # @return [String] an EIP-191 prefixed string.
     def prefix_message(message)
-      "#{EIP191_PREFIX_BYTE}Ethereum Signed Message:\n#{message.size}#{message}"
+      "#{EIP191_PREFIX_BYTE}Ethereum Signed Message:\n#{message.bytesize}#{message}"
     end
 
     # Dissects a signature blob of 65+ bytes into its `r`, `s`, and `v`

diff --git a/spec/eth/signature_spec.rb b/spec/eth/signature_spec.rb
@@ -8,6 +8,11 @@
       proof = "This is proof that I, user A, have access to this address."
       expect(Signature.prefix_message proof).to eq "\x19Ethereum Signed Message:\n58This is proof that I, user A, have access to this address."
     end
+
+    it "can properly prefix messages with multibyte characters" do
+      hello = "Hello World!🌏"
+      expect(Signature.prefix_message hello).to eq "\x19Ethereum Signed Message:\n16Hello World!🌏"
+    end
   end
 
   describe ".dissect" do