Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth/abi: raise error if numeric comes as string #114

Merged
merged 2 commits into from
Jun 27, 2022
Merged

eth/abi: raise error if numeric comes as string #114

merged 2 commits into from
Jun 27, 2022

Conversation

q9f
Copy link
Owner

@q9f q9f commented Jun 13, 2022

There is no way to tell whether a string is a decimal, octal, hexadecimal, etc.

Reverts #112

@q9f q9f added the wontfix This will not be worked on label Jun 13, 2022
@q9f q9f changed the title Revert "eth/abi: allow parsing numerics from string inputs" eth/abi: raise error if numeric comes as string Jun 15, 2022
kurotaky
kurotaky approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@kurotaky kurotaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 😖

@q9f q9f merged commit 19e7c20 into main Jun 27, 2022
@q9f q9f deleted the revert-112-q9f/abi/string branch June 27, 2022 07:52
mculp pushed a commit to mculp/eth.rb that referenced this pull request Aug 1, 2022
@q9f @mculp
eth/abi: raise error if numeric comes as string (q9f#114)
1d34b37 
* Revert "eth/abi: allow parsing numerics from string inputs (q9f#112)"

This reverts commit bb640c7.

* eth/abi: raise error if numeric comes as string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurotaky kurotaky kurotaky approved these changes

Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@q9f @kurotaky