Use QString literals #16652
Use QString literals #16652
Conversation
Chocobo1
added
the
Code cleanup
Chocobo1
force-pushed
the
literal
branch
2 times, most recently
from
300431e to
ed29427
Compare
|
@now-im @xavier2k6 The solution is simple, see below: UIThemeManager::instance()->getIcon("document-properties"); // if the conflict is here
UIThemeManager::instance()->getIcon(u"document-properties"_qs); // add the 'u' prefix and '_qs' postfix to fix it
UIThemeManager::instance()->getIcon(QLatin1String("document-properties")); // here there should be no conflict so you don't have to do modify anything *for now*
// in the future it will be changed to the following as well
UIThemeManager::instance()->getIcon(u"document-properties"_qs); |
|
@Chocobo1 Got it. Thanks. |
Thank you, shouldn't be too much of a problem. @now-im If you run in to problems re-basing etc. give me a shout. (I'm still currently not getting notification from mentions etc. but I should come across things when I'm looking through the Issues tickets/PR's) |
Ok. |
This patch covers src/gui and some leftovers from previous commit.
|
@glassez |
|
@Chocobo1 @xavier2k6 Successfully rebased. |
| @@ -168,7 +168,7 @@ QVariant TransferListModel::headerData(int section, Qt::Orientation orientation, | |||
| { | |||
| switch (section) | |||
| { | |||
| case TR_QUEUE_POSITION: return QChar('#'); | |||
| case TR_QUEUE_POSITION: return u'#'; | |||
There was a problem hiding this comment.
This column is now shown as "35". Any char in place of # here returns a number as column name.
There was a problem hiding this comment.
Well, QVariant treats char16_t as numeric type so you still need to explicitly tell it that we want QChar or QString:
case TR_QUEUE_POSITION: return QChar(u'#'); or case TR_QUEUE_POSITION: return u'#'_qs;
There was a problem hiding this comment.
thanks, will fix.
UPDATE: fixed in PR #16669.
This patch covers src/gui and some leftovers from previous commit.