Use QString literals #16669
Merged
Use QString literals #16669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chocobo1
added
the
Code cleanup
Merged
glassez
reviewed
Mar 19, 2022
| @@ -72,8 +72,8 @@ namespace | |||
| { | |||
| QJsonArray categoriesInfo | |||
| {QJsonObject { | |||
| {QLatin1String("id"), "all"}, | |||
| {QLatin1String("name"), SearchPluginManager::categoryFullName("all")} | |||
| {QLatin1String("id"), u"all"_qs}, | |||
There was a problem hiding this comment.
Did you intentionally skip these QLatin1String entries?
There was a problem hiding this comment.
Yes, I want to have QT_NO_CAST_FROM_ASCII defined first.
There was a problem hiding this comment.
I've also noticed places like QString::fromLatin1("some string") in the code that need to be replaced with u"some string"_qs.
This will come later too.
It covers src/webui and enables `QT_NO_CAST_FROM_ASCII`.
glassez
approved these changes
Mar 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It covers src/webui and enables
QT_NO_CAST_FROM_ASCII.