Backport changes to v5.0 branch #20996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR restores the users previously used tab (Transfer, Search, RSS, etc.) when the WebUI is reloaded. PR qbittorrent#20705.
The cookie value can only contain ASCII characters.
PR qbittorrent#20913. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Chocobo1 <Chocobo1@users.noreply.github.com>
Add "BT" (BitTorrent) to avoid confusion about which protocol it is referring to. Also its value doesn't need to be translated. PR qbittorrent#20897.
PR qbittorrent#20833. --------- Co-authored-by: Vladimir Golovnev <glassez@yandex.ru> Co-authored-by: Chocobo1 <Chocobo1@users.noreply.github.com>
A few code are revised because the type checker (mypy) doesn't allow changing types on a variable. PR qbittorrent#20935.
1. Previously unhandled connections will stay in pending state. It won't be closed until timeout happened. This may lead to wasting system resources. Now the (over-limit) connection is actively rejected. 2. When out-of-memory occurs here, reject the new connection instead of throwing exception and crash. 3. Also clean up some unused bits. PR qbittorrent#20961.
… of 0 Fixes the download progress calculation for folders with zero size. Previously, the progress would be Zero. Now, folders with zero size show 100% progress. PR qbittorrent#20567.
The canonical type for `size_string` is `str`. However numeric types are also accepted in order to accommodate poorly written plugins. PR qbittorrent#20976.
Previously `m_shutdownTimeout * 1000` was calculated in `int` and now it is `qint64`. PR qbittorrent#20982.
Chocobo1
previously approved these changes
Jun 27, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
glassez
previously approved these changes
Jul 7, 2024
|
The backport of this PR? #20951 (after the merger) |
glassez
previously approved these changes
Jul 8, 2024
PR qbittorrent#20951. --------- Co-authored-by: Chocobo1 <Chocobo1@users.noreply.github.com> Co-authored-by: Vladimir Golovnev <glassez@yandex.ru> Co-authored-by: thalieht <thalieht@users.noreply.github.com>
|
Should we merge this & open a new PR for any further backports? |
xavier2k6
approved these changes
Jul 22, 2024
Well, let's do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of PR #20918 with the conflicts resolved.
There was only one commit that conflicted:
master version: cb90b67
v5 version: 4687b4e
Files in conflict: