-
-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVG and raster images can be embedded in project #4563
Conversation
@andreasneumann @rduivenvoorde you were among the happiest people 😄 when the feature was committed. Can you check whether there's some valuable information missing or that i'd have misunderstood, please? |
QGIS needs to resolve the path in order to display the corresponding image | ||
* load the file from a remote URL: as above, on the success of the connection | ||
depends the image retrieval | ||
* embed the SVG file into the item: the file is saved as a base64 string within |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"the file is saved as a base64 string within"
Is this relevant for users? It's not exposed anywhere, and could potentially be changed in future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just "the file is embedded inside the current project, style database, or print layout template."
* embed the SVG file into the item: the file is saved as a base64 string within | ||
the symbol or label, and also in the project, an associated style or a print | ||
layout template file. THe SVG file is then always rendered as part of the item. | ||
A convenient way to share projects with custom SVG symbols. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a convenient way to create self-contained projects with custom SVG symbols which can be easily shared amongst different users and installations of QGIS.
@nyalldawson Thanks for the quick review. Any element regarding the print layout case? |
It's not currently supported in print layouts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to help by updating some comments and adding some of @nyalldawson's comments as suggestions.
Co-Authored-By: Håvard Tveite <havard.tveite@nmbu.no> Co-Authored-By: Nyall Dawson <nyall.dawson@gmail.com>
Fix #3219, fix #3216, fix #2815, fix #2814