Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fill symbol layers description #4641

Merged
merged 3 commits into from
Dec 17, 2019
Merged

Conversation

DelazJ
Copy link
Collaborator

@DelazJ DelazJ commented Dec 17, 2019

Fix #3208, fix #3695

Copy link
Contributor

@havatv havatv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have some suggestions (mostly language related).

source/docs/user_manual/style_library/symbol_selector.rst Outdated Show resolved Hide resolved
source/docs/user_manual/style_library/symbol_selector.rst Outdated Show resolved Hide resolved
source/docs/user_manual/style_library/symbol_selector.rst Outdated Show resolved Hide resolved
source/docs/user_manual/style_library/symbol_selector.rst Outdated Show resolved Hide resolved
source/docs/user_manual/style_library/symbol_selector.rst Outdated Show resolved Hide resolved
source/docs/user_manual/style_library/symbol_selector.rst Outdated Show resolved Hide resolved
source/docs/user_manual/style_library/symbol_selector.rst Outdated Show resolved Hide resolved
source/docs/user_manual/style_library/symbol_selector.rst Outdated Show resolved Hide resolved
source/docs/user_manual/style_library/symbol_selector.rst Outdated Show resolved Hide resolved
DelazJ and others added 2 commits December 17, 2019 10:37
Co-Authored-By: Håvard Tveite <havard.tveite@nmbu.no>
Co-Authored-By: Håvard Tveite <havard.tveite@nmbu.no>
@DelazJ DelazJ merged commit 9418ebb into qgis:master Dec 17, 2019
@DelazJ DelazJ deleted the fillSymbolLayer branch December 17, 2019 10:05
@@ -200,7 +200,7 @@ Appropriate for point geometry features, marker symbols have several

* **Raster image marker**: use an image (:file:`PNG`, :file:`JPG`, :file:`BMP` ...)
as marker symbol. The image can be a file on the disk, a remote URL
or an embedded file encoded as a base64 string (:ref:`more details <svg_paths>`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DelazJ, why the "embedded file encoded as a base64 string" part was removed? It is possible to use a base64 string as a raster image marker or an SVG marker.
See qgis/QGIS#8613.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
I think they are two different things: this one is about the possibility to use a base64 string as a Raster image marker or as an SVG marker (this is a very useful feature that let the user use e.g. an image in a BLOB field with the Data Defined Override and an expression like 'base64:' || to_base64( "blob_field"); the other one, if I'm not wrong, is about (the technical details on) how a raster image file or an svg file is saved if embedded in an item.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the old text was actually addressing your point (at least, not from my understanding at that time) but well, I agree with getting it back, preferably with the expression sample (to clarify for end users). Would you mind opening a PR, please? Thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants