-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce pollution of system directories during test runs #57606
Conversation
c2e9ab5
to
7079e9b
Compare
CI reported failure is:
https://github.com/qgis/QGIS/actions/runs/9284356490/job/25547985232?pr=57606#step:13:905 |
Defines a QGIS_TEST_TMP_DIR variable in top-level CMakeLists.txt and then defines QGIS_CUSTOM_CONFIG_PATH and TMPDIR to be under that directory for individual tests. Closes qgisGH-50587 Closes qgisGH-48884
For the record: this is the count of files found in the tmp/ directory after
All those will now at least be under a single directory, to make their removal easier (with this PR) |
f22e0ad
to
da11a8a
Compare
The failure in this PR is due to a bug in a test which is fixed by GH-57612 -- once that is merged this can be rebased |
Hey @strk, this looks like a pretty trivial PR, but nobody seems to be available to merge it. But it doesn't look obviously wrong to me. Do you want me to file an identical PR that you could approve, working around the slow review times? It would mean bypassing the merge rules, but if nobody complains maybe that's fine. |
@strk I need to revert this -- it's broken my build and causes running tests from a non-installed build to segfault. |
@nyalldawson could you file a separate ticket and add a stacktrace ? A segfault upon specifying a custom tmpdir is most likely a missing check in a testcase |
|
This is an amended cherry-pick of commit da11a8a which was reverted in commit a0e6e16 by Nyall Dawson The amendment is a fix in QString syntax as spotted by Nyall in qgis#57606 (review)
This is an amended cherry-pick of commit da11a8a which was reverted in commit a0e6e16 by Nyall Dawson The amendment is a fix in QString syntax as spotted by Nyall in qgis#57606 (review)
Closes GH-57610
Closes GH-50587
Closes GH-48884