-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop polluting filesystem (replay) #57934
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still has issues @strk. You don't check to see if that folder exists anywhere, neither is it ever cleaned up. You're trading proper operating system temporary file handling for storing everything in some custom location which is NEVER cleaned up.
This reverts commit a3391e6.
This reverts commit d64fbe2.
This is an amended cherry-pick of commit da11a8a which was reverted in commit a0e6e16 by Nyall Dawson The amendment is a fix in QString syntax as spotted by Nyall in qgis#57606 (review)
9179b43
to
e482323
Compare
Given CI is green, may I ask you to give more details about what fails ? Note I filed at least 14 tickets about non-working testsuite when run locally but most of the times those issues are disregarded because "CI works!". I'm happy to improve offline testsuite experience but I need more details about what is not working for you. So: how exactly those missing checks break the run for you ? Could you see a way to encode those situations in the CI so I can get a red here instead of a green ? |
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
Hi, as we are building qgis on a mutliuser basis on the same big-cpu-ram server, we encounter issues with the mixed up of temp files in the /tmp. As our different users build different branches, we cannot use the same user for everyone. And tests fail due to conflicts on the files generated by tests owned by different users. Do you have some updates about the last remaining issues? Do some tests are still failing? Regards |
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
This is a re-proposition of PR GH-57606 after all commits in that PR were reverted
This PR addresses the problem reported by @nyalldawson in #57606 (review) (reportedly causing a segfault on his system)