-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in lorentzian plot for spectroscopies #742
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #742 +/- ##
=======================================
Coverage 96.44% 96.44%
=======================================
Files 108 108
Lines 7509 7509
=======================================
Hits 7242 7242
Misses 267 267
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This makes the line appear correctly in qubit spectroscopy for me, but still for resonator spectroscopy at low power it did not appear. Could it be that it failed to fit? I don't even see the table with the fitted values when that is the case. |
When the fit fails you should not see both the table and the plot with the fit. |
This has been addressed here 72873bb in #744 because the issue was similar. |
Closes #741.
There was no error in the fit since also the table shows the correct fitted value, the problem was just a factor 10^9 in the plot.
It is possible to test the fit by simply running
and to generate the new report
Checklist:
master
main
main