Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in lorentzian plot for spectroscopies #742

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

andrea-pasquale
Copy link
Contributor

@andrea-pasquale andrea-pasquale commented Mar 3, 2024

Closes #741.
There was no error in the fit since also the table shows the correct fitted value, the problem was just a factor 10^9 in the plot.
It is possible to test the fit by simply running

qq fit <output_folder>

and to generate the new report

qq report <output_folder>

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

@andrea-pasquale andrea-pasquale added the bug Something isn't working label Mar 3, 2024
@andrea-pasquale andrea-pasquale added this to the Qibocal 0.0.8 milestone Mar 3, 2024
@andrea-pasquale andrea-pasquale self-assigned this Mar 3, 2024
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (ddba2d3) to head (4d86289).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #742   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files         108      108           
  Lines        7509     7509           
=======================================
  Hits         7242     7242           
  Misses        267      267           
Flag Coverage Δ
unittests 96.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/qibocal/protocols/characterization/utils.py 96.65% <ø> (ø)

@igres26
Copy link
Contributor

igres26 commented Mar 4, 2024

This makes the line appear correctly in qubit spectroscopy for me, but still for resonator spectroscopy at low power it did not appear. Could it be that it failed to fit? I don't even see the table with the fitted values when that is the case.

@andrea-pasquale
Copy link
Contributor Author

This makes the line appear correctly in qubit spectroscopy for me, but still for resonator spectroscopy at low power it did not appear. Could it be that it failed to fit? I don't even see the table with the fitted values when that is the case.

When the fit fails you should not see both the table and the plot with the fit.
It seems weird to me, please share the report where the fitting does not appear.

@andrea-pasquale
Copy link
Contributor Author

This makes the line appear correctly in qubit spectroscopy for me, but still for resonator spectroscopy at low power it did not appear. Could it be that it failed to fit? I don't even see the table with the fitted values when that is the case.

This has been addressed here 72873bb in #744 because the issue was similar.

@andrea-pasquale andrea-pasquale added this pull request to the merge queue Mar 8, 2024
Merged via the queue into main with commit b811472 Mar 8, 2024
21 checks passed
@andrea-pasquale andrea-pasquale deleted the fix_spectroscopy branch March 8, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resonator spectroscopy fit fails
4 participants