Solve missing plot for protocols involving chi2

[andrea-pasquale]

Fixing issue spotted by @igres26 in qiboteam/qibolab_platforms_qrc#119 (comment).
The problem was caused by a side effect introduced in #707.

Checklist:

• Reviewers confirm new code works as expected.
• Tests are passing.
• Coverage does not decrease.
• Documentation is updated.
• Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
  • Qibo: master
  • Qibolab: main
  • Qibolab_platforms_qrc: main

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.73%. Comparing base (ddba2d3) to head (cfd1c08).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #744      +/-   ##
==========================================
+ Coverage   96.44%   96.73%   +0.28%     
==========================================
  Files         108      108              
  Lines        7509     7498      -11     
==========================================
+ Hits         7242     7253      +11     
+ Misses        267      245      -22     

Flag	Coverage Δ
unittests	96.73% <100.00%> (+0.28%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
.../protocols/characterization/coherence/spin_echo.py	100.00% <100.00%> (ø)
...ols/characterization/coherence/spin_echo_signal.py	100.00% <100.00%> (+5.06%)	⬆️
...qibocal/protocols/characterization/coherence/t1.py	100.00% <100.00%> (ø)
...otocols/characterization/coherence/t1_sequences.py	100.00% <100.00%> (ø)
.../protocols/characterization/coherence/t1_signal.py	100.00% <100.00%> (+6.77%)	⬆️
...qibocal/protocols/characterization/coherence/t2.py	100.00% <100.00%> (ø)
.../protocols/characterization/coherence/t2_signal.py	100.00% <100.00%> (+6.89%)	⬆️
...bocal/protocols/characterization/coherence/zeno.py	100.00% <100.00%> (ø)
...rotocols/characterization/coherence/zeno_signal.py	100.00% <100.00%> (ø)
src/qibocal/protocols/characterization/flipping.py	96.55% <100.00%> (-0.35%)	⬇️
... and 7 more

... and 2 files with indirect coverage changes

[igres26]

This has fixed the issue for me.

[igres26]

Although this makes the plot appear again, which fixes the issue, I have got some instances of a reported value of chi2 of around 10^27, which just doesn't seem right.

[andrea-pasquale]

For chi2 I've also seen some weird values. We are using the same formula for all protocols. I can have a look.

[andrea-pasquale]

Although this makes the plot appear again, which fixes the issue, I have got some instances of a reported value of chi2 of around 10^27, which just doesn't seem right.

Fixed in cfd1c08.

[stavros11]

Thanks, seems to work for the resonator spectroscopy (http://login.qrccluster.com:9000/Li931HqmSzO2xCvEhTwtmw==) but only together with #742.

[andrea-pasquale]

Thanks, seems to work for the resonator spectroscopy (http://login.qrccluster.com:9000/Li931HqmSzO2xCvEhTwtmw==) but only together with #742.

Indeed, probably I could have made one PR point to the other. Thanks for checking!