-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs #30
Comments
Closing this as completed in PR #35 . |
I would say that PR #35 introduced the bare minimum, and it's not even properly rendering I would keep this to properly review and extend the documentation, possibly beyond what is already in the README (that still contains more info than the docs), and trim the README itself after that. |
Thanks for the checking @alecandido . I remember I saw this rendering issue before, and applied a fix commit to it. But, maybe the commit was not properly picked up, so the issue showed up again. Anyway, I've started a new PR #44 and fixed the rendering. It's still WIP, and we'll add some reasonably concrete content to make it a basic guide. |
The rendering issue seems to stick around for It is fixed though in To avoid this rendering issue, is re-direct to the |
I believe that it is just an interesting instance of a bug in the docs workflow (still unknown). It will fix on its own after merging/releasing something else, no need to rush for a dedicated fix. It is interesting because it is showing up in the first release, so, essentially, it is retaining a previous state of |
Thanks @alecandido for the insight. The fact that merging/releasing something will fix on its own hints to me that the |
It's more complicated than that. Usually, if you go in the artifact that is generated by the workflow, and check the docs, they are the correct ones (both |
As a continuation to #51, I've proposed a PR #57 to add a note about valid computation settings for QuimbBackend. The error in #51 is due to setting every possible computation setting to False. For useful computation, one of MPS or expectation should be enabled. In order to use the quimb backend's dense vector function, MPS_enabled must be True since the function uses mps_opts for its calculation. I've proposed a PR to add a note for the user in the doc to let them know that this would be an invalid configuration for computation settings #57 Additionally, error handling can be introduced under quimb.py as follows: mps_enabled_value = runcard.get("MPS_enabled") |
Sphinx documentation is missing.
At the moment, only the README material is provided as user guide. As soon as docs will be available, I'd move even the bulk of it there, and keep in the README just a minimal example, without documenting all the options (i.e. set the backend through Qibo, execute a circuit).
User guide with the description, and exposing benefits and limitations of the available options, will be much appreciated.
The text was updated successfully, but these errors were encountered: