Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct usage of computation_settings #57

Closed
wants to merge 1 commit into from

Conversation

NithyasriVS
Copy link
Member

@NithyasriVS NithyasriVS commented Apr 1, 2024

This is PR proposed, inspired from #51

Using a configuration where all computation settings are set to False may not be a meaningful way to use qibotn as the user no longer knows what their output is a computation of, especially as more features/computations get added to the QuimbBackend in the future. So, it could be useful to restrict the user from wanting to use the configuration where are settings are False

Thus, a note has been added in the docs under "Setting the runcard" section as follows:

"Note that either MPS_enabled or expectation_enabled must be set to True to be able to perform any useful calulations with the QuimbBackend. Thus, it is compulsary to set one of them to true according to whether the user wants to calculate the dense vector or expectation value."

This was referenced Apr 1, 2024
@NithyasriVS
Copy link
Member Author

Discussion done on the same and concluded that documentation can be further extended if needed in the future.

@NithyasriVS NithyasriVS closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant