Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the rendering issue, refine the content. #44

Merged
merged 22 commits into from
Mar 4, 2024
Merged

Fix the rendering issue, refine the content. #44

merged 22 commits into from
Mar 4, 2024

Conversation

liweintu
Copy link
Contributor

@liweintu liweintu commented Mar 3, 2024

This PR is to fix the rendering issue and refine the content.

@liweintu
Copy link
Contributor Author

liweintu commented Mar 3, 2024

The rendering issue is fixed now. It's still a WIP as the content needs refinement.

@Tankya2 , @Vinitha-balachandran Could you help add a bit more detailed content to make the doc a reasonably basic guide. Also, some code block does not match with the description above, please refine the code block as well.

@liweintu liweintu mentioned this pull request Mar 3, 2024
@scarrazza
Copy link
Member

@liweintu @Vinitha-balachandran as you know, we have to release this package as soon as possible, therefore please apply your changes asap and make this PR ready for review.

@liweintu
Copy link
Contributor Author

liweintu commented Mar 4, 2024

@liweintu @Vinitha-balachandran as you know, we have to release this package as soon as possible, therefore please apply your changes asap and make this PR ready for review.

Yes, we're working on it now. Thanks for the reminder and help of the commits.

@liweintu liweintu marked this pull request as ready for review March 4, 2024 08:49
@liweintu liweintu requested review from alecandido and scarrazza March 4, 2024 08:49
@liweintu
Copy link
Contributor Author

liweintu commented Mar 4, 2024

Ok, this PR is ready for review. @alecandido @scarrazza Could you help take a look please?

src/qibotn/circuit_to_mps.py Outdated Show resolved Hide resolved
src/qibotn/circuit_convertor.py Outdated Show resolved Hide resolved
src/qibotn/circuit_convertor.py Outdated Show resolved Hide resolved
src/qibotn/circuit_convertor.py Outdated Show resolved Hide resolved
src/qibotn/circuit_convertor.py Outdated Show resolved Hide resolved
@alecandido alecandido merged commit 3ce7836 into main Mar 4, 2024
6 checks passed
@alecandido alecandido deleted the doc-fix branch March 4, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants