feat: add compress api for coro client #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
helintongh
commented
Jun 10, 2024
•
helintongh
commented
- add multiple encoding type support
- add encoding for coro client
- coro server add accept-encoding check
|
Code Coverage Report |
qicosmos
reviewed
Jun 11, 2024
include/cinatra/coro_http_client.hpp
Outdated
Comment on lines
1441
to
1447
| if (parser_.get_header_value("Content-Encoding") == "gzip") | ||
| encoding_type_ = content_encoding::gzip; | ||
| else if (parser_.get_header_value("Content-Encoding") == "deflate") | ||
| encoding_type_ = content_encoding::deflate; | ||
| } |
There was a problem hiding this comment.
这里有点问题，"Content-Encoding"可能有多个字段，有可能一个字段有多个encoding方式，比如：
"Content-Encoding":"gzip"
"Content-Encoding":"deflate"或者
"Content-Encoding": "gzip, deflate, br"另外reply的时候如果发现set_status_and_content时已经设置了gzip或者deflate，就按设置的方式去reply，如果没有设置，但是头里面又能找到gzip或者deflate，那么就默认选择gzip；如果只有一种encoding就按头里面的来。
如果头里面没有Content-Encoding，但是用户设置response的时候又指定了gzip或deflate，则忽略它，不去压缩。
There was a problem hiding this comment.
设置response的时候是解析客户端的Accept-Encoding，如果包含当前用户设置的按照用户设置的reponse进行响应。
如果不包含或无此字段则按照原始的响应
1. add multiple encoding type support 2. add encoding for coro client 3. coro server add accept-encoding check
helintongh
force-pushed
the
feat_client_add_compress_support
branch
from
c46cbf5 to
f101377
Compare
|
Code Coverage Report |
|
Code Coverage Report |
qicosmos
reviewed
Jun 12, 2024
| @@ -145,6 +145,25 @@ class coro_http_request { | |||
|
|
|||
| bool is_req_ranges() { return parser_.is_req_ranges(); } | |||
|
|
|||
| std::string get_accept_encoding() { | |||
| @@ -52,26 +52,63 @@ class coro_http_response { | |||
| } | |||
| void set_status_and_content( | |||
| status_type status, std::string content = "", | |||
| content_encoding encoding = content_encoding::none) { | |||
| set_status_and_content_view(status, std::move(content), encoding, false); | |||
There was a problem hiding this comment.
std::string client_encoding_type的类型改成std::string_view
|
Code Coverage Report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.