-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add compress api for coro client #597
Merged
qicosmos
merged 2 commits into
qicosmos:master
from
helintongh:feat_client_add_compress_support
Jun 12, 2024
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,26 +52,63 @@ class coro_http_response { | |
} | ||
void set_status_and_content( | ||
status_type status, std::string content = "", | ||
content_encoding encoding = content_encoding::none) { | ||
set_status_and_content_view(status, std::move(content), encoding, false); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. std::string client_encoding_type的类型改成std::string_view There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 已经修改 |
||
content_encoding encoding = content_encoding::none, | ||
std::string client_encoding_type = "") { | ||
set_status_and_content_view(status, std::move(content), encoding, false, | ||
client_encoding_type); | ||
} | ||
|
||
template <typename String> | ||
void set_status_and_content_view( | ||
status_type status, String content = "", | ||
content_encoding encoding = content_encoding::none, bool is_view = true) { | ||
content_encoding encoding = content_encoding::none, bool is_view = true, | ||
std::string_view client_encoding_type = "") { | ||
status_ = status; | ||
#ifdef CINATRA_ENABLE_GZIP | ||
if (encoding == content_encoding::gzip) { | ||
std::string encode_str; | ||
bool r = gzip_codec::compress(content, encode_str, true); | ||
if (!r) { | ||
set_status_and_content(status_type::internal_server_error, | ||
"gzip compress error"); | ||
if (client_encoding_type.empty() || | ||
client_encoding_type.find("gzip") != std::string_view::npos) { | ||
std::string encode_str; | ||
bool r = gzip_codec::compress(content, encode_str, true); | ||
if (!r) { | ||
set_status_and_content(status_type::internal_server_error, | ||
"gzip compress error"); | ||
} | ||
else { | ||
add_header("Content-Encoding", "gzip"); | ||
set_content(std::move(encode_str)); | ||
} | ||
} | ||
else { | ||
if (is_view) { | ||
content_view_ = content; | ||
} | ||
else { | ||
content_ = std::move(content); | ||
} | ||
} | ||
} | ||
else if (encoding == content_encoding::deflate) { | ||
if (client_encoding_type.empty() || | ||
client_encoding_type.find("deflate") != std::string_view::npos) { | ||
std::string deflate_str; | ||
bool r = gzip_codec::deflate(content, deflate_str); | ||
if (!r) { | ||
set_status_and_content(status_type::internal_server_error, | ||
"deflate compress error"); | ||
} | ||
else { | ||
add_header("Content-Encoding", "deflate"); | ||
set_content(std::move(deflate_str)); | ||
} | ||
} | ||
else { | ||
add_header("Content-Encoding", "gzip"); | ||
set_content(std::move(encode_str)); | ||
if (is_view) { | ||
content_view_ = content; | ||
} | ||
else { | ||
content_ = std::move(content); | ||
} | ||
} | ||
} | ||
else | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
返回类型改成std::string_view