fix: the code publishing workflow #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrossinek
commented
Jul 22, 2024
| @@ -10,7 +11,6 @@ jobs: | |||
| pypi: | |||
| name: pypi | |||
| runs-on: ubuntu-latest | |||
| needs: github | |||
There was a problem hiding this comment.
This was a left-over dependency I forgot to remove. I used to have two jobs in here, the first one was called github and the pypi job would only run once the other had passed.
| @@ -1,6 +1,7 @@ | |||
| name: Publish release | |||
|
|
|||
| on: | |||
| workflow_dispatch: | |||
There was a problem hiding this comment.
I am adding this to enable us to manually trigger this job. Normally it will automatically run whenever a tag gets pushed so manual intervention should really only be needed in cases where the action fails (like this time).
timmintam
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.