Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the code publishing workflow #74

Merged
merged 1 commit into from
Jul 22, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/publish_code.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: Publish release

on:
workflow_dispatch:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am adding this to enable us to manually trigger this job. Normally it will automatically run whenever a tag gets pushed so manual intervention should really only be needed in cases where the action fails (like this time).

push:
tags:
- "[0-9]+.[0-9]+.[0-9]+*"
Expand All @@ -10,7 +11,6 @@ jobs:
pypi:
name: pypi
runs-on: ubuntu-latest
needs: github
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a left-over dependency I forgot to remove. I used to have two jobs in here, the first one was called github and the pypi job would only run once the other had passed.

steps:
- name: Checkout tag
uses: actions/checkout@v4
Expand Down