Minor tidy up of key overrides (#13747)

* Minor tidy up of key overrides * Update quantum/quantum.c * Update quantum/quantum.c
qmk · Jul 28, 2021 · 4ef8ff4 · 4ef8ff4
1 parent 50964ae
commit 4ef8ff4
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 39 deletions.
diff --git a/common_features.mk b/common_features.mk
@@ -334,11 +334,6 @@ ifeq ($(strip $(PRINTING_ENABLE)), yes)
     SRC += $(TMK_DIR)/protocol/serial_uart.c
 endif
 
-ifeq ($(strip $(KEY_OVERRIDE_ENABLE)), yes)
-    OPT_DEFS += -DKEY_OVERRIDE_ENABLE
-    SRC += $(QUANTUM_DIR)/process_keycode/process_key_override.c
-endif
-
 ifeq ($(strip $(SERIAL_LINK_ENABLE)), yes)
     SERIAL_SRC := $(wildcard $(SERIAL_PATH)/protocol/*.c)
     SERIAL_SRC += $(wildcard $(SERIAL_PATH)/system/*.c)
@@ -663,6 +658,11 @@ ifeq ($(strip $(COMBO_ENABLE)), yes)
     OPT_DEFS += -DCOMBO_ENABLE
 endif
 
+ifeq ($(strip $(KEY_OVERRIDE_ENABLE)), yes)
+    SRC += $(QUANTUM_DIR)/process_keycode/process_key_override.c
+    OPT_DEFS += -DKEY_OVERRIDE_ENABLE
+endif
+
 ifeq ($(strip $(TAP_DANCE_ENABLE)), yes)
     SRC += $(QUANTUM_DIR)/process_keycode/process_tap_dance.c
     OPT_DEFS += -DTAP_DANCE_ENABLE

diff --git a/quantum/process_keycode/process_key_override.c b/quantum/process_keycode/process_key_override.c
@@ -380,7 +380,7 @@ static bool try_activating_override(const uint16_t keycode, const uint8_t layer,
     return true;
 }
 
-void matrix_scan_key_override(void) {
+void key_override_task(void) {
     if (deferred_register == 0) {
         return;
     }

diff --git a/quantum/process_keycode/process_key_override.h b/quantum/process_keycode/process_key_override.h
@@ -92,16 +92,22 @@ typedef struct {
 extern const key_override_t **key_overrides;
 
 /** Turns key overrides on */
-extern void key_override_on(void);
+void key_override_on(void);
 
 /** Turns key overrides off */
-extern void key_override_off(void);
+void key_override_off(void);
 
 /** Toggles key overrides on */
-extern void key_override_toggle(void);
+void key_override_toggle(void);
 
 /** Returns whether key overrides are enabled */
-extern bool key_override_is_enabled(void);
+bool key_override_is_enabled(void);
+
+/** Handling of key overrides and its implemented keycodes */
+bool process_key_override(const uint16_t keycode, const keyrecord_t *const record);
+
+/** Perform any deferred keys */
+void key_override_task(void);
 
 /**
  *  Preferrably use these macros to create key overrides. They fix many of the options to a standard setting that should satisfy most basic use-cases. Only directly create a key_override_t struct when you really need to.

diff --git a/quantum/process_keycode/process_key_override_private.h b/quantum/process_keycode/process_key_override_private.h
diff --git a/quantum/quantum.c b/quantum/quantum.c
@@ -55,10 +55,6 @@ float default_layer_songs[][16][2] = DEFAULT_LAYER_SONGS;
 #    include "process_auto_shift.h"
 #endif
 
-#ifdef KEY_OVERRIDE_ENABLE
-#    include "process_key_override_private.h"
-#endif
-
 uint8_t extract_mod_bits(uint16_t code) {
     switch (code) {
         case QK_MODS ... QK_MODS_MAX:
@@ -415,7 +411,7 @@ void matrix_scan_quantum() {
 #endif
 
 #ifdef KEY_OVERRIDE_ENABLE
-    matrix_scan_key_override();
+    key_override_task();
 #endif
 
 #ifdef SEQUENCER_ENABLE