Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor tidy up of key overrides #13747

Merged
merged 3 commits into from
Jul 28, 2021
Merged

Minor tidy up of key overrides #13747

merged 3 commits into from
Jul 28, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jul 28, 2021 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jul 28, 2021
@zvecr zvecr requested a review from a team July 28, 2021 00:28
zvecr
zvecr commented Jul 28, 2021
View reviewed changes
quantum/quantum.c Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from a team July 28, 2021 01:45
@zvecr zvecr merged commit 4ef8ff4 into qmk:develop Jul 28, 2021
@JonasGessner
Copy link

Could you mention me/request a review from me when any other changes to key overrides come up in the future? Would be nice so that I know what's going on with it and possibly provide input!

nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@zvecr @nhongooi
Minor tidy up of key overrides (qmk#13747)
f535b69 
* Minor tidy up of key overrides

* Update quantum/quantum.c

* Update quantum/quantum.c
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr
Minor tidy up of key overrides (qmk#13747)
1135211 
* Minor tidy up of key overrides

* Update quantum/quantum.c

* Update quantum/quantum.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna left review comments

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zvecr @JonasGessner @drashna @fauxpark