Use cursor position as start index for oled_write_raw and oled_write_raw_P #10800

daveallie · 2020-10-30T04:37:05Z

The documentation for these APIs say that they write to the buffer from the current cursor position, but they would always write from the start of the buffer irrespective of the current cursor.

Description

Use the current cursor position as the start location to write the raw data to the oled buffer.

Docs: https://github.com/qmk/qmk_firmware/blob/master/docs/feature_oled_driver.md#L283-L290

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

…raw_P The documentation for these APIs say that they write to the buffer from the current current position, but they would always write from the start of the buffer irrespective of the current cursor.

drashna · 2020-11-01T20:08:28Z

@XScorpion2 If you wanted to weigh in here?

XScorpion2 · 2020-11-01T21:30:06Z

Good catch

noroadsleft

__attribute__ ((weak)) ✔️

No experience with OLEDs, but the code change looks good.

* Branch point for 2020 November 28 Breaking Change * Remove matrix_col_t to allow MATRIX_ROWS > 32 (#10183) * Add support for soft serial to ATmega32U2 (#10204) * Change MIDI velocity implementation to allow direct control of velocity value (#9940) * Add ability to build a subset of all keyboards based on platform. * Actually use eeprom_driver_init(). * Make bootloader_jump weak for ChibiOS. (#10417) * Joystick 16-bit support (#10439) * Per-encoder resolutions (#10259) * Share button state from mousekey to pointing_device (#10179) * Add hotfix for chibios keyboards not wake (#10088) * Add advanced/efficient RGB Matrix Indicators (#8564) * Naming change. * Support for STM32 GPIOF,G,H,I,J,K (#10206) * Add milc as a dependency and remove the installed milc (#10563) * ChibiOS upgrade: early init conversions (#10214) * ChibiOS upgrade: configuration file migrator (#9952) * Haptic and solenoid cleanup (#9700) * XD75 cleanup (#10524) * OLED display update interval support (#10388) * Add definition based on currently-selected serial driver. (#10716) * New feature: Retro Tapping per key (#10622) * Allow for modification of output RGB values when using rgblight/rgb_matrix. (#10638) * Add housekeeping task callbacks so that keyboards/keymaps are capable of executing code for each main loop iteration. (#10530) * Rescale both ChibiOS and AVR backlighting. * Reduce Helix keyboard build variation (#8669) * Minor change to behavior allowing display updates to continue between task ticks (#10750) * Some GPIO manipulations in matrix.c change to atomic. (#10491) * qmk cformat (#10767) * [Keyboard] Update the Speedo firmware for v3.0 (#10657) * Maartenwut/Maarten namechange to evyd13/Evy (#10274) * [quantum] combine repeated lines of code (#10837) * Add step sequencer feature (#9703) * aeboards/ext65 refactor (#10820) * Refactor xelus/dawn60 for Rev2 later (#10584) * add DEBUG_MATRIX_SCAN_RATE_ENABLE to common_features.mk (#10824) * [Core] Added `add_oneshot_mods` & `del_oneshot_mods` (#10549) * update chibios os usb for the otg driver (#8893) * Remove HD44780 References, Part 4 (#10735) * [Keyboard] Add Valor FRL TKL (+refactor) (#10512) * Fix cursor position bug in oled_write_raw functions (#10800) * Fixup version.h writing when using SKIP_VERSION=yes (#10972) * Allow for certain code in the codebase assuming length of string. (#10974) * Add AT90USB support for serial.c (#10706) * Auto shift: support repeats and early registration (#9826) * Rename ledmatrix.h to match .c file (#7949) * Split RGB_MATRIX_ENABLE into _ENABLE and _DRIVER (#10231) * Split LED_MATRIX_ENABLE into _ENABLE and _DRIVER (#10840) * Merge point for 2020 Nov 28 Breaking Change

* Branch point for 2020 November 28 Breaking Change * Remove matrix_col_t to allow MATRIX_ROWS > 32 (qmk#10183) * Add support for soft serial to ATmega32U2 (qmk#10204) * Change MIDI velocity implementation to allow direct control of velocity value (qmk#9940) * Add ability to build a subset of all keyboards based on platform. * Actually use eeprom_driver_init(). * Make bootloader_jump weak for ChibiOS. (qmk#10417) * Joystick 16-bit support (qmk#10439) * Per-encoder resolutions (qmk#10259) * Share button state from mousekey to pointing_device (qmk#10179) * Add hotfix for chibios keyboards not wake (qmk#10088) * Add advanced/efficient RGB Matrix Indicators (qmk#8564) * Naming change. * Support for STM32 GPIOF,G,H,I,J,K (qmk#10206) * Add milc as a dependency and remove the installed milc (qmk#10563) * ChibiOS upgrade: early init conversions (qmk#10214) * ChibiOS upgrade: configuration file migrator (qmk#9952) * Haptic and solenoid cleanup (qmk#9700) * XD75 cleanup (qmk#10524) * OLED display update interval support (qmk#10388) * Add definition based on currently-selected serial driver. (qmk#10716) * New feature: Retro Tapping per key (qmk#10622) * Allow for modification of output RGB values when using rgblight/rgb_matrix. (qmk#10638) * Add housekeeping task callbacks so that keyboards/keymaps are capable of executing code for each main loop iteration. (qmk#10530) * Rescale both ChibiOS and AVR backlighting. * Reduce Helix keyboard build variation (qmk#8669) * Minor change to behavior allowing display updates to continue between task ticks (qmk#10750) * Some GPIO manipulations in matrix.c change to atomic. (qmk#10491) * qmk cformat (qmk#10767) * [Keyboard] Update the Speedo firmware for v3.0 (qmk#10657) * Maartenwut/Maarten namechange to evyd13/Evy (qmk#10274) * [quantum] combine repeated lines of code (qmk#10837) * Add step sequencer feature (qmk#9703) * aeboards/ext65 refactor (qmk#10820) * Refactor xelus/dawn60 for Rev2 later (qmk#10584) * add DEBUG_MATRIX_SCAN_RATE_ENABLE to common_features.mk (qmk#10824) * [Core] Added `add_oneshot_mods` & `del_oneshot_mods` (qmk#10549) * update chibios os usb for the otg driver (qmk#8893) * Remove HD44780 References, Part 4 (qmk#10735) * [Keyboard] Add Valor FRL TKL (+refactor) (qmk#10512) * Fix cursor position bug in oled_write_raw functions (qmk#10800) * Fixup version.h writing when using SKIP_VERSION=yes (qmk#10972) * Allow for certain code in the codebase assuming length of string. (qmk#10974) * Add AT90USB support for serial.c (qmk#10706) * Auto shift: support repeats and early registration (qmk#9826) * Rename ledmatrix.h to match .c file (qmk#7949) * Split RGB_MATRIX_ENABLE into _ENABLE and _DRIVER (qmk#10231) * Split LED_MATRIX_ENABLE into _ENABLE and _DRIVER (qmk#10840) * Merge point for 2020 Nov 28 Breaking Change

The documentation for these APIs say that they write to the buffer from the current current position, but they would always write from the start of the buffer irrespective of the current cursor.

github-actions bot added the core label Oct 30, 2020

noroadsleft force-pushed the develop branch from 92ca6b9 to c3221d4 Compare October 30, 2020 20:23

Use cursor position as start index for oled_write_raw and oled_write_…

45ac99f

…raw_P The documentation for these APIs say that they write to the buffer from the current current position, but they would always write from the start of the buffer irrespective of the current cursor.

daveallie force-pushed the oled_write_raw-cursor-position branch from 6747467 to 45ac99f Compare October 31, 2020 03:26

drashna requested a review from a team November 1, 2020 20:07

XScorpion2 approved these changes Nov 1, 2020

View reviewed changes

noroadsleft approved these changes Nov 8, 2020

View reviewed changes

noroadsleft requested a review from a team November 8, 2020 18:55

drashna approved these changes Nov 15, 2020

View reviewed changes

drashna merged commit f7ae095 into qmk:develop Nov 15, 2020

daveallie deleted the oled_write_raw-cursor-position branch November 26, 2020 09:27

bcat mentioned this pull request Jun 13, 2021

[Bug] oled_write_raw overruns data buffer, corrupts display when cursor not at origin (0, 0) #13203

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use cursor position as start index for oled_write_raw and oled_write_raw_P #10800

Use cursor position as start index for oled_write_raw and oled_write_raw_P #10800

daveallie commented Oct 30, 2020 •

edited

Loading

drashna commented Nov 1, 2020

XScorpion2 commented Nov 1, 2020

noroadsleft left a comment

Use cursor position as start index for oled_write_raw and oled_write_raw_P #10800

Use cursor position as start index for oled_write_raw and oled_write_raw_P #10800

Conversation

daveallie commented Oct 30, 2020 • edited Loading

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

drashna commented Nov 1, 2020

XScorpion2 commented Nov 1, 2020

noroadsleft left a comment

Choose a reason for hiding this comment

daveallie commented Oct 30, 2020 •

edited

Loading