Rename ledmatrix.h to match .c file #7949

fauxpark · 2020-01-21T08:04:50Z

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Maxr1998 · 2020-01-21T11:13:22Z

Not sure, but could it be that this file was named that way to avoid conflicts with the led_matrix.h provided by tmk (/tmk_core/protocol/arm_atsam/led_matrix.h)? I see some keyboard specifically importing that one. I think we have to rename ours to qmk_led_matrix.h or something like that.

fauxpark · 2020-01-21T11:25:11Z

That would certainly explain the giant errors Travis is giving for the Drop boards... argh. I would rather rename the ATSAM one, TBH. The QMK LED matrix feature is meant to be closely related to the RGB matrix feature, and you can see the similarities between led_matrix.[ch] and rgb_matrix.[ch].

Maxr1998 · 2020-01-21T12:16:38Z

That's certainly possible, but would require some changes to the keyboard configs. But nothing a grep & sed couldn't fix ;)

skullydazed · 2020-01-21T17:13:29Z

I would rather rename the ATSAM one, TBH.

I would too, but it was something I didn't have the cycles for at the time. So I went with ledmatrix.h instead for the time being.

ridingqwerty

LGTM

Maxr1998

As I wrote above, I think we should first rename the existing led_matrix.h in tmk.

ridingqwerty · 2020-01-21T22:11:13Z

As I wrote above, I think we should first rename the existing led_matrix.h in tmk.

I missed the clarifying discussion. Agree with putting this on hold.

fauxpark · 2020-08-28T17:45:05Z

Taking this off hold, will move to develop for next cycle.

* Branch point for 2020 November 28 Breaking Change * Remove matrix_col_t to allow MATRIX_ROWS > 32 (#10183) * Add support for soft serial to ATmega32U2 (#10204) * Change MIDI velocity implementation to allow direct control of velocity value (#9940) * Add ability to build a subset of all keyboards based on platform. * Actually use eeprom_driver_init(). * Make bootloader_jump weak for ChibiOS. (#10417) * Joystick 16-bit support (#10439) * Per-encoder resolutions (#10259) * Share button state from mousekey to pointing_device (#10179) * Add hotfix for chibios keyboards not wake (#10088) * Add advanced/efficient RGB Matrix Indicators (#8564) * Naming change. * Support for STM32 GPIOF,G,H,I,J,K (#10206) * Add milc as a dependency and remove the installed milc (#10563) * ChibiOS upgrade: early init conversions (#10214) * ChibiOS upgrade: configuration file migrator (#9952) * Haptic and solenoid cleanup (#9700) * XD75 cleanup (#10524) * OLED display update interval support (#10388) * Add definition based on currently-selected serial driver. (#10716) * New feature: Retro Tapping per key (#10622) * Allow for modification of output RGB values when using rgblight/rgb_matrix. (#10638) * Add housekeeping task callbacks so that keyboards/keymaps are capable of executing code for each main loop iteration. (#10530) * Rescale both ChibiOS and AVR backlighting. * Reduce Helix keyboard build variation (#8669) * Minor change to behavior allowing display updates to continue between task ticks (#10750) * Some GPIO manipulations in matrix.c change to atomic. (#10491) * qmk cformat (#10767) * [Keyboard] Update the Speedo firmware for v3.0 (#10657) * Maartenwut/Maarten namechange to evyd13/Evy (#10274) * [quantum] combine repeated lines of code (#10837) * Add step sequencer feature (#9703) * aeboards/ext65 refactor (#10820) * Refactor xelus/dawn60 for Rev2 later (#10584) * add DEBUG_MATRIX_SCAN_RATE_ENABLE to common_features.mk (#10824) * [Core] Added `add_oneshot_mods` & `del_oneshot_mods` (#10549) * update chibios os usb for the otg driver (#8893) * Remove HD44780 References, Part 4 (#10735) * [Keyboard] Add Valor FRL TKL (+refactor) (#10512) * Fix cursor position bug in oled_write_raw functions (#10800) * Fixup version.h writing when using SKIP_VERSION=yes (#10972) * Allow for certain code in the codebase assuming length of string. (#10974) * Add AT90USB support for serial.c (#10706) * Auto shift: support repeats and early registration (#9826) * Rename ledmatrix.h to match .c file (#7949) * Split RGB_MATRIX_ENABLE into _ENABLE and _DRIVER (#10231) * Split LED_MATRIX_ENABLE into _ENABLE and _DRIVER (#10840) * Merge point for 2020 Nov 28 Breaking Change

* Branch point for 2020 November 28 Breaking Change * Remove matrix_col_t to allow MATRIX_ROWS > 32 (qmk#10183) * Add support for soft serial to ATmega32U2 (qmk#10204) * Change MIDI velocity implementation to allow direct control of velocity value (qmk#9940) * Add ability to build a subset of all keyboards based on platform. * Actually use eeprom_driver_init(). * Make bootloader_jump weak for ChibiOS. (qmk#10417) * Joystick 16-bit support (qmk#10439) * Per-encoder resolutions (qmk#10259) * Share button state from mousekey to pointing_device (qmk#10179) * Add hotfix for chibios keyboards not wake (qmk#10088) * Add advanced/efficient RGB Matrix Indicators (qmk#8564) * Naming change. * Support for STM32 GPIOF,G,H,I,J,K (qmk#10206) * Add milc as a dependency and remove the installed milc (qmk#10563) * ChibiOS upgrade: early init conversions (qmk#10214) * ChibiOS upgrade: configuration file migrator (qmk#9952) * Haptic and solenoid cleanup (qmk#9700) * XD75 cleanup (qmk#10524) * OLED display update interval support (qmk#10388) * Add definition based on currently-selected serial driver. (qmk#10716) * New feature: Retro Tapping per key (qmk#10622) * Allow for modification of output RGB values when using rgblight/rgb_matrix. (qmk#10638) * Add housekeeping task callbacks so that keyboards/keymaps are capable of executing code for each main loop iteration. (qmk#10530) * Rescale both ChibiOS and AVR backlighting. * Reduce Helix keyboard build variation (qmk#8669) * Minor change to behavior allowing display updates to continue between task ticks (qmk#10750) * Some GPIO manipulations in matrix.c change to atomic. (qmk#10491) * qmk cformat (qmk#10767) * [Keyboard] Update the Speedo firmware for v3.0 (qmk#10657) * Maartenwut/Maarten namechange to evyd13/Evy (qmk#10274) * [quantum] combine repeated lines of code (qmk#10837) * Add step sequencer feature (qmk#9703) * aeboards/ext65 refactor (qmk#10820) * Refactor xelus/dawn60 for Rev2 later (qmk#10584) * add DEBUG_MATRIX_SCAN_RATE_ENABLE to common_features.mk (qmk#10824) * [Core] Added `add_oneshot_mods` & `del_oneshot_mods` (qmk#10549) * update chibios os usb for the otg driver (qmk#8893) * Remove HD44780 References, Part 4 (qmk#10735) * [Keyboard] Add Valor FRL TKL (+refactor) (qmk#10512) * Fix cursor position bug in oled_write_raw functions (qmk#10800) * Fixup version.h writing when using SKIP_VERSION=yes (qmk#10972) * Allow for certain code in the codebase assuming length of string. (qmk#10974) * Add AT90USB support for serial.c (qmk#10706) * Auto shift: support repeats and early registration (qmk#9826) * Rename ledmatrix.h to match .c file (qmk#7949) * Split RGB_MATRIX_ENABLE into _ENABLE and _DRIVER (qmk#10231) * Split LED_MATRIX_ENABLE into _ENABLE and _DRIVER (qmk#10840) * Merge point for 2020 Nov 28 Breaking Change

fauxpark added the core label Jan 21, 2020

fauxpark requested a review from a team January 21, 2020 08:04

fauxpark changed the title ~~Rename ledmatrix.c to match .c file~~ Rename ledmatrix.h to match .c file Jan 21, 2020

ridingqwerty previously approved these changes Jan 21, 2020

View reviewed changes

fauxpark added the on hold label Jan 21, 2020

Maxr1998 suggested changes Jan 21, 2020

View reviewed changes

drashna requested review from ridingqwerty and a team January 22, 2020 01:59

fauxpark dismissed ridingqwerty’s stale review via cdfc5cd August 28, 2020 17:43

fauxpark force-pushed the ledmatrix-header branch from 5bdcd3a to cdfc5cd Compare August 28, 2020 17:43

fauxpark removed the on hold label Aug 28, 2020

fauxpark changed the base branch from master to develop August 30, 2020 06:34

fauxpark force-pushed the ledmatrix-header branch from cdfc5cd to bf27d4b Compare August 30, 2020 06:34

noroadsleft force-pushed the develop branch from 3a8e1b8 to a1b96ba Compare September 4, 2020 22:03

fauxpark force-pushed the ledmatrix-header branch from bf27d4b to 065b701 Compare September 5, 2020 12:01

fauxpark added enhancement keyboard keymap labels Sep 5, 2020

fauxpark mentioned this pull request Sep 5, 2020

Update file changes action #10245

Merged

14 tasks

noroadsleft force-pushed the develop branch from a1b96ba to 3430907 Compare September 12, 2020 11:47

fauxpark force-pushed the ledmatrix-header branch from 065b701 to 5200bbd Compare September 12, 2020 12:15

skullydazed force-pushed the develop branch from fa8cf59 to cce70f1 Compare October 18, 2020 21:10

fauxpark force-pushed the ledmatrix-header branch from 5200bbd to bab0deb Compare October 18, 2020 21:25

noroadsleft force-pushed the develop branch from 5720202 to dcefc1a Compare October 23, 2020 22:37

fauxpark force-pushed the ledmatrix-header branch from bab0deb to db7e1cc Compare October 24, 2020 05:54

skullydazed force-pushed the develop branch from db745a9 to 68fc044 Compare October 28, 2020 02:16

fauxpark force-pushed the ledmatrix-header branch from db7e1cc to 549684c Compare October 29, 2020 03:43

noroadsleft force-pushed the develop branch from 92ca6b9 to c3221d4 Compare October 30, 2020 20:23

fauxpark force-pushed the ledmatrix-header branch from 549684c to e704967 Compare October 30, 2020 20:37

fauxpark force-pushed the ledmatrix-header branch from e704967 to c26411c Compare November 22, 2020 17:13

fauxpark added 3 commits November 28, 2020 21:43

Rename ledmatrix.c to match .c file

9bc63eb

Rename Massdrop led_matrix to md_rgb_matrix

7afd9a8

Fix a couple function names

fef807f

fauxpark force-pushed the ledmatrix-header branch from c26411c to fef807f Compare November 28, 2020 10:48

noroadsleft approved these changes Nov 28, 2020

View reviewed changes

fauxpark merged commit 6b3e56b into qmk:develop Nov 28, 2020

fauxpark deleted the ledmatrix-header branch November 28, 2020 11:03

BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024

Rename ledmatrix.h to match .c file (qmk#7949)

793300a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename ledmatrix.h to match .c file #7949

Rename ledmatrix.h to match .c file #7949

fauxpark commented Jan 21, 2020 •

edited

Loading

Maxr1998 commented Jan 21, 2020

fauxpark commented Jan 21, 2020

Maxr1998 commented Jan 21, 2020 •

edited

Loading

skullydazed commented Jan 21, 2020

ridingqwerty left a comment

Maxr1998 left a comment

ridingqwerty commented Jan 21, 2020

fauxpark commented Aug 28, 2020

Rename ledmatrix.h to match .c file #7949

Rename ledmatrix.h to match .c file #7949

Conversation

fauxpark commented Jan 21, 2020 • edited Loading

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

Maxr1998 commented Jan 21, 2020

fauxpark commented Jan 21, 2020

Maxr1998 commented Jan 21, 2020 • edited Loading

skullydazed commented Jan 21, 2020

ridingqwerty left a comment

Choose a reason for hiding this comment

Maxr1998 left a comment

Choose a reason for hiding this comment

ridingqwerty commented Jan 21, 2020

fauxpark commented Aug 28, 2020

fauxpark commented Jan 21, 2020 •

edited

Loading

Maxr1998 commented Jan 21, 2020 •

edited

Loading