Translated 'feature_advanced_keycodes.md'. #12454

s-show · 2021-04-01T14:53:54Z

Description

Add Japanese translation of docs/feature_advanced_keycodes.md.

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

mtei · 2021-04-01T21:36:20Z

@umi-umi @shelaf @hsgw @satt99 @takashiski @yoshihara よかったらレビューお願いします。

mtei · 2021-04-01T21:48:01Z

見てみたら、@shelaf さんの #10673 で同じファイルに変更かけてますね。こっちに統合するのでどうでしょうか？

s-show · 2021-04-01T22:14:20Z

@shelaf さんのプルリクを見落としていました。#10673 に統合するのは全然構わないので、方法を勉強して対処したいと思います。

mtei · 2021-04-02T01:54:53Z

私は、どちらでもいいのですが、ベースがより新しいこの pr に統合するのはどうでしよう？というつもりで上のコメントを書きました。わかりにくくてすみません。

s-show · 2021-04-03T07:07:15Z

私の方に統合することには全く異存はありませんので、あとは @shelaf さんの意向に従います。

shelaf · 2021-04-03T07:39:19Z

#10673 と修正範囲がかぶっていない(このPRが正しい修正になっていない)ので、私の方のを先にマージしてしまって、その後このPRをrebaseすれば良いと思いますがどうでしょうか。

mtei · 2021-04-03T11:31:46Z

私の方のを先にマージしてしまって、その後

なるほど、そうですね。そうしましょう。

docs/ja/feature_advanced_keycodes.md

Co-authored-by: shela <shelaf@users.noreply.github.com>

docs/ja/feature_advanced_keycodes.md

mtei · 2021-06-24T21:15:27Z

docs/ja/feature_advanced_keycodes.md

+        // 左 Alt だけがアクティブか検知します
+        if ((get_mods() & MOD_BIT(KC_LALT)) == MOD_BIT(KC_LALT)) {


このコメントと、一つ前の段落の説明のとおり動作をするには、この if は間違っている...
翻訳としては、仕方ないのでこのまま放置ですが。

Co-authored-by: Takeshi ISHII <2170248+mtei@users.noreply.github.com>

mtei · 2021-06-26T18:14:38Z

I think this is ready to merge.

mtei · 2021-07-01T09:21:47Z

Thanks!

* qmk/develop: (25 commits) [Core] Unite half-duplex and full-duplex serial drivers (qmk#13081) Add missing Quefrency layouts for QMK Configurator (qmk#13384) [Keyboard] Adding Via support to the GON NerD60 (qmk#13395) [Keymap] Add haervig userspace and keymaps (qmk#13362) Convert Dip Switch callbacks to boolean functions (qmk#13399) Changed Yeehaw Default Keymap (qmk#13341) [Docs] update Japanese translation of other_eclipse.md (qmk#12776) update Japanese translation of config_options.md (qmk#12695) Translated 'feature_advanced_keycodes.md'. (qmk#12454) [Docs] Japanese translation of docs/keycodes_basic.md (qmk#11044) Illusion Rosa: correct layout macro names (qmk#13387) FJLabs Midway60: physically arrange layout macro and fix info.json data (qmk#13386) Sanctified Dystopia: physically arrange layout macro (qmk#13385) Updates for keymap: ut472/stefanopace (qmk#13370) [Keyboard] update debounce time on kint boards (qmk#13351) [Keymap] RGB Timeout added to userspace (qmk#13339) [Keyboard][Bug] Fix LED indicators on Skeletn87 (qmk#13335) [Keyboard] Pteron36, open source 3x5_3 supporting layout (qmk#13313) Drashna's split updates (qmk#13350) [Keymap] Create bingocaller keymap for DZ60RGB-ANSI (qmk#13311) ...

* Translated 'feature_advanced_keycodes.md'. * Update docs/ja/feature_advanced_keycodes.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/feature_advanced_keycodes.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/feature_advanced_keycodes.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/feature_advanced_keycodes.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/feature_advanced_keycodes.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/feature_advanced_keycodes.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/feature_advanced_keycodes.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/feature_advanced_keycodes.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/feature_advanced_keycodes.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/feature_advanced_keycodes.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/feature_advanced_keycodes.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/feature_advanced_keycodes.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/feature_advanced_keycodes.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/feature_advanced_keycodes.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/feature_advanced_keycodes.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/feature_advanced_keycodes.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/feature_advanced_keycodes.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/feature_advanced_keycodes.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/feature_advanced_keycodes.md Co-authored-by: shela <shelaf@users.noreply.github.com> * Update docs/ja/feature_advanced_keycodes.md Co-authored-by: shela <shelaf@users.noreply.github.com> * update based on comment. * update based on comment. Co-authored-by: Takeshi ISHII <2170248+mtei@users.noreply.github.com> * update based on comment. Co-authored-by: Takeshi ISHII <2170248+mtei@users.noreply.github.com> * update based on comment. Co-authored-by: Takeshi ISHII <2170248+mtei@users.noreply.github.com> Co-authored-by: shela <shelaf@users.noreply.github.com> Co-authored-by: Takeshi ISHII <2170248+mtei@users.noreply.github.com>

Translated 'feature_advanced_keycodes.md'.

55843f2

github-actions bot added documentation translation labels Apr 1, 2021

shelaf reviewed Apr 7, 2021

View reviewed changes

s-show and others added 19 commits April 12, 2021 22:52

Update docs/ja/feature_advanced_keycodes.md

999a6be

Co-authored-by: shela <shelaf@users.noreply.github.com>

Update docs/ja/feature_advanced_keycodes.md

09b5fb0

Co-authored-by: shela <shelaf@users.noreply.github.com>

Update docs/ja/feature_advanced_keycodes.md

17e55c2

Co-authored-by: shela <shelaf@users.noreply.github.com>

Update docs/ja/feature_advanced_keycodes.md

e58015e

Co-authored-by: shela <shelaf@users.noreply.github.com>

Update docs/ja/feature_advanced_keycodes.md

e10b5e3

Co-authored-by: shela <shelaf@users.noreply.github.com>

Update docs/ja/feature_advanced_keycodes.md

33f5cd8

Co-authored-by: shela <shelaf@users.noreply.github.com>

Update docs/ja/feature_advanced_keycodes.md

07bd318

Co-authored-by: shela <shelaf@users.noreply.github.com>

Update docs/ja/feature_advanced_keycodes.md

2d84f9a

Co-authored-by: shela <shelaf@users.noreply.github.com>

Update docs/ja/feature_advanced_keycodes.md

23470bc

Co-authored-by: shela <shelaf@users.noreply.github.com>

Update docs/ja/feature_advanced_keycodes.md

7dbf190

Co-authored-by: shela <shelaf@users.noreply.github.com>

Update docs/ja/feature_advanced_keycodes.md

2371894

Co-authored-by: shela <shelaf@users.noreply.github.com>

Update docs/ja/feature_advanced_keycodes.md

afa2db0

Co-authored-by: shela <shelaf@users.noreply.github.com>

Update docs/ja/feature_advanced_keycodes.md

fbce7f5

Co-authored-by: shela <shelaf@users.noreply.github.com>

Update docs/ja/feature_advanced_keycodes.md

2e34184

Co-authored-by: shela <shelaf@users.noreply.github.com>

Update docs/ja/feature_advanced_keycodes.md

96cb24f

Co-authored-by: shela <shelaf@users.noreply.github.com>

Update docs/ja/feature_advanced_keycodes.md

bc1ef90

Co-authored-by: shela <shelaf@users.noreply.github.com>

Update docs/ja/feature_advanced_keycodes.md

cffa525

Co-authored-by: shela <shelaf@users.noreply.github.com>

Update docs/ja/feature_advanced_keycodes.md

dfb0478

Co-authored-by: shela <shelaf@users.noreply.github.com>

Update docs/ja/feature_advanced_keycodes.md

91d3cde

Co-authored-by: shela <shelaf@users.noreply.github.com>

s-show and others added 2 commits April 12, 2021 22:55

Update docs/ja/feature_advanced_keycodes.md

2d07cf1

Co-authored-by: shela <shelaf@users.noreply.github.com>

update based on comment.

324b02c

s-show mentioned this pull request May 8, 2021

Add ID to "## Advanced Macros". #12830

Merged

14 tasks

shelaf approved these changes May 17, 2021

View reviewed changes

mtei reviewed Jun 25, 2021

View reviewed changes

mtei and others added 4 commits June 26, 2021 03:25

Merge branch 'master' into translate_feature_advanced_keycodes.md

087d723

update based on comment.

1407ca1

Co-authored-by: Takeshi ISHII <2170248+mtei@users.noreply.github.com>

update based on comment.

c7d99cb

Co-authored-by: Takeshi ISHII <2170248+mtei@users.noreply.github.com>

update based on comment.

0662a83

Co-authored-by: Takeshi ISHII <2170248+mtei@users.noreply.github.com>

mtei approved these changes Jun 26, 2021

View reviewed changes

mtei requested a review from a team June 26, 2021 18:09

mtei merged commit 397d388 into qmk:master Jul 1, 2021

s-show deleted the translate_feature_advanced_keycodes.md branch July 6, 2021 13:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Translated 'feature_advanced_keycodes.md'. #12454

Translated 'feature_advanced_keycodes.md'. #12454

s-show commented Apr 1, 2021

mtei commented Apr 1, 2021

mtei commented Apr 1, 2021

s-show commented Apr 1, 2021

mtei commented Apr 2, 2021 •

edited

Loading

s-show commented Apr 3, 2021

shelaf commented Apr 3, 2021

mtei commented Apr 3, 2021

mtei Jun 24, 2021 •

edited

Loading

mtei commented Jun 26, 2021

mtei commented Jul 1, 2021

		// 左 Alt だけがアクティブか検知します
		if ((get_mods() & MOD_BIT(KC_LALT)) == MOD_BIT(KC_LALT)) {

Translated 'feature_advanced_keycodes.md'. #12454

Translated 'feature_advanced_keycodes.md'. #12454

Conversation

s-show commented Apr 1, 2021

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

mtei commented Apr 1, 2021

mtei commented Apr 1, 2021

s-show commented Apr 1, 2021

mtei commented Apr 2, 2021 • edited Loading

s-show commented Apr 3, 2021

shelaf commented Apr 3, 2021

mtei commented Apr 3, 2021

mtei Jun 24, 2021 • edited Loading

Choose a reason for hiding this comment

mtei commented Jun 26, 2021

mtei commented Jul 1, 2021

mtei commented Apr 2, 2021 •

edited

Loading

mtei Jun 24, 2021 •

edited

Loading