keyboards/kint*: update debounce time to 20ms to fix ghost key presses #13351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, should I rebase this on the |
|
Yes, it can go to master. |
related to kinx-project/kint#39 related to qmk#12626
stapelberg
force-pushed
the
kinesis-debounce
branch
from
b868089 to
8ddb7f8
Compare
|
Okay! Updated the PR to target the |
fauxpark
approved these changes
Jun 26, 2021
|
Friendly ping on this bugfix PR? |
drashna
approved these changes
Jul 1, 2021
cadusk
pushed a commit
to cadusk/qmk_firmware
that referenced
this pull request
Jul 2, 2021
* qmk/develop: (25 commits) [Core] Unite half-duplex and full-duplex serial drivers (qmk#13081) Add missing Quefrency layouts for QMK Configurator (qmk#13384) [Keyboard] Adding Via support to the GON NerD60 (qmk#13395) [Keymap] Add haervig userspace and keymaps (qmk#13362) Convert Dip Switch callbacks to boolean functions (qmk#13399) Changed Yeehaw Default Keymap (qmk#13341) [Docs] update Japanese translation of other_eclipse.md (qmk#12776) update Japanese translation of config_options.md (qmk#12695) Translated 'feature_advanced_keycodes.md'. (qmk#12454) [Docs] Japanese translation of docs/keycodes_basic.md (qmk#11044) Illusion Rosa: correct layout macro names (qmk#13387) FJLabs Midway60: physically arrange layout macro and fix info.json data (qmk#13386) Sanctified Dystopia: physically arrange layout macro (qmk#13385) Updates for keymap: ut472/stefanopace (qmk#13370) [Keyboard] update debounce time on kint boards (qmk#13351) [Keymap] RGB Timeout added to userspace (qmk#13339) [Keyboard][Bug] Fix LED indicators on Skeletn87 (qmk#13335) [Keyboard] Pteron36, open source 3x5_3 supporting layout (qmk#13313) Drashna's split updates (qmk#13350) [Keymap] Create bingocaller keymap for DZ60RGB-ANSI (qmk#13311) ...
jakeprime
pushed a commit
to jakeprime/qmk_firmware
that referenced
this pull request
Jul 10, 2021
related to kinx-project/kint#39 related to qmk#12626
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Jul 11, 2021
related to kinx-project/kint#39 related to qmk#12626
wox
pushed a commit
to wox/qmk_firmware
that referenced
this pull request
Aug 14, 2021
related to kinx-project/kint#39 related to qmk#12626
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
related to kinx-project/kint#39 related to qmk#12626
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have multiple user reports (kinx-project/kint#39 and #12626) of ghost key press issues due to the short default debounce time of 5ms.
As the comment states, well-worn Cherry MX key switches as used in the Kinesis Advantage keyboards can produce noise for more than the 5ms specified in the Cherry data sheets.
Types of Changes
Issues Fixed or Closed by This PR
Checklist