Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyboards/kint*: update debounce time to 20ms to fix ghost key presses #13351

Merged
merged 1 commit into from
Jul 1, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions keyboards/kinesis/kint2pp/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,12 @@
#define LED_COMPOSE_PIN C3
#define LED_PIN_ON_STATE 0

/* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */
#define DEBOUNCE 5
/* Well-worn Cherry MX key switches can bounce for up to 20ms, despite the
* Cherry data sheet specifying 5ms. Because we use the sym_eager_pk debounce
* algorithm, this debounce latency only affects key releases (not key
* presses). */
#undef DEBOUNCE
#define DEBOUNCE 20

#define IGNORE_MOD_TAP_INTERRUPT

Expand Down
8 changes: 6 additions & 2 deletions keyboards/kinesis/kint36/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,12 @@
/* COL2ROW or ROW2COL */
#define DIODE_DIRECTION COL2ROW

/* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */
#define DEBOUNCE 5
/* Well-worn Cherry MX key switches can bounce for up to 20ms, despite the
* Cherry data sheet specifying 5ms. Because we use the sym_eager_pk debounce
* algorithm, this debounce latency only affects key releases (not key
* presses). */
#undef DEBOUNCE
#define DEBOUNCE 20

#define IGNORE_MOD_TAP_INTERRUPT

Expand Down