Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Han60 QMK / VIA Support #15332

Merged
merged 9 commits into from
Dec 1, 2021
Merged

Han60 QMK / VIA Support #15332

merged 9 commits into from
Dec 1, 2021

Conversation

farhandsome
Copy link

@farhandsome farhandsome commented Nov 28, 2021 •
edited
Loading

Description

Adding QMK / VIA support for the upcoming keyboard Han60.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Nov 28, 2021
@farhandsome farhandsome changed the title Han60 QMK Support Han60 QMK / VIA Support Nov 28, 2021
@farhandsome farhandsome mentioned this pull request Nov 28, 2021
Closed
14 tasks
drashna
drashna requested changes Nov 28, 2021
View reviewed changes
keyboards/han60/rules.mk Outdated Show resolved Hide resolved
@farhandsome @drashna
Removed Bluetooth line.
cc92520 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@drashna drashna requested a review from a team November 28, 2021 08:26
zvecr
zvecr requested changes Nov 28, 2021
View reviewed changes
keyboards/han60/han60.h Outdated Show resolved Hide resolved
keyboards/han60/han60.h Outdated Show resolved Hide resolved
keyboards/han60/info.json Outdated Show resolved Hide resolved
keyboards/han60/info.json Outdated Show resolved Hide resolved
keyboards/han60/readme.md Outdated Show resolved Hide resolved
farhandsome and others added 5 commits November 28, 2021 14:23
@farhandsome @zvecr
Update keyboards/han60/info.json
96d03ba 
Co-authored-by: Joel Challis <git@zvecr.com>
@farhandsome @zvecr
Update keyboards/han60/info.json
68cf099 
Co-authored-by: Joel Challis <git@zvecr.com>
@farhandsome @zvecr
Update keyboards/han60/han60.h
776b938 
Co-authored-by: Joel Challis <git@zvecr.com>
@farhandsome @zvecr
Update keyboards/han60/han60.h
91f6dc4 
Co-authored-by: Joel Challis <git@zvecr.com>
@farhandsome
Updated to include image and description.
bfd027a
@farhandsome farhandsome requested a review from zvecr November 28, 2021 20:29
fauxpark
fauxpark requested changes Nov 29, 2021
View reviewed changes
keyboards/han60/readme.md Outdated Show resolved Hide resolved
@farhandsome @fauxpark
Updated imgur link URL
75b3549 
Co-authored-by: Ryan <fauxpark@gmail.com>
@farhandsome farhandsome requested a review from fauxpark November 29, 2021 18:34
drashna
drashna reviewed Dec 1, 2021
View reviewed changes
keyboards/han60/rules.mk Outdated Show resolved Hide resolved
@farhandsome @drashna
Update keyboards/han60/rules.mk
566dabe 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@drashna drashna merged commit b6d9a80 into qmk:master Dec 1, 2021
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Dec 2, 2021
Merge remote-tracking branch 'qmk/develop' into develop
09b3951 
* qmk/develop: (76 commits)
  Update ReadMe for the Roopad (qmk#15380)
  Tidy up existing i2c_master implementations (qmk#15376)
  Remove pointless `CUSTOM_MATRIX = no` (qmk#15383)
  Remove manual enable of LTO within keyboards (qmk#15377)
  [Keyboard] Han60 QMK / VIA Support (qmk#15332)
  Convert ai03/orbit to SPLIT_KEYBOARD (qmk#15340)
  Convert not_so_minidox to SPLIT_KEYBOARD (qmk#15306)
  Tidy up `SLEEP_LED_ENABLE` rules (qmk#15362)
  [Keyboard] Add support for Mode SixtyFive M65HA and M65HI (qmk#14685)
  Implement MAGIC_TOGGLE_CONTROL_CAPSLOCK (qmk#15368)
  Rename Layout Macros for TKLs with F13 keys (qmk#15361)
  [Docs] Reorder functions in Understanding QMK (qmk#15357)
  [Keyboard] Fix up Endgame34 (qmk#15366)
  [Keyboard] Fix compilation issues for Ploopy Trackball classic (qmk#15364)
  [Keyboard] Add missng define for 4x6 Tractyl Manuform (qmk#15363)
  [Core] Added chconf.h for WB32 (qmk#15359)
  [Keyboard] kangaroo improvements (qmk#15350)
  [Keyboard] Convert ergoinu to SPLIT_KEYBOARD (qmk#15305)
  [Keymap] Keebio Sinc layout with macOS support (qmk#15324)
  Fixup paths for `ramonimbao/wete/v2`. (qmk#15360)
  ...
@farhandsome farhandsome mentioned this pull request Dec 7, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@farhandsome @drashna @fauxpark @zvecr